Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: Source/core/layout/compositing/DeprecatedPaintLayerCompositor.h

Issue 1149303002: Add a dirty bit for updateDescendantDependentFlags. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: try again. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/layout/compositing/DeprecatedPaintLayerCompositor.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 GraphicsLayer* layerForHorizontalScrollbar() const { return m_layerForHorizo ntalScrollbar.get(); } 152 GraphicsLayer* layerForHorizontalScrollbar() const { return m_layerForHorizo ntalScrollbar.get(); }
153 GraphicsLayer* layerForVerticalScrollbar() const { return m_layerForVertical Scrollbar.get(); } 153 GraphicsLayer* layerForVerticalScrollbar() const { return m_layerForVertical Scrollbar.get(); }
154 GraphicsLayer* layerForScrollCorner() const { return m_layerForScrollCorner. get(); } 154 GraphicsLayer* layerForScrollCorner() const { return m_layerForScrollCorner. get(); }
155 155
156 void resetTrackedPaintInvalidationRects(); 156 void resetTrackedPaintInvalidationRects();
157 void setTracksPaintInvalidations(bool); 157 void setTracksPaintInvalidations(bool);
158 158
159 virtual String debugName(const GraphicsLayer*) override; 159 virtual String debugName(const GraphicsLayer*) override;
160 DocumentLifecycle& lifecycle() const; 160 DocumentLifecycle& lifecycle() const;
161 161
162 bool needsUpdateDescendantDependentFlags() const { return m_needsUpdateDesce ndantDependentFlags; }
163 void setNeedsUpdateDescendantDependentFlags() { m_needsUpdateDescendantDepen dentFlags = true; }
164
162 void updatePotentialCompositingReasonsFromStyle(DeprecatedPaintLayer*); 165 void updatePotentialCompositingReasonsFromStyle(DeprecatedPaintLayer*);
163 166
164 // Whether the layer could ever be composited. 167 // Whether the layer could ever be composited.
165 bool canBeComposited(const DeprecatedPaintLayer*) const; 168 bool canBeComposited(const DeprecatedPaintLayer*) const;
166 169
167 // FIXME: Move allocateOrClearCompositedDeprecatedPaintLayerMapping to Compo sitingLayerAssigner once we've fixed 170 // FIXME: Move allocateOrClearCompositedDeprecatedPaintLayerMapping to Compo sitingLayerAssigner once we've fixed
168 // the compositing chicken/egg issues. 171 // the compositing chicken/egg issues.
169 bool allocateOrClearCompositedDeprecatedPaintLayerMapping(DeprecatedPaintLay er*, CompositingStateTransitionType compositedLayerUpdate); 172 bool allocateOrClearCompositedDeprecatedPaintLayerMapping(DeprecatedPaintLay er*, CompositingStateTransitionType compositedLayerUpdate);
170 173
171 void updateDirectCompositingReasons(DeprecatedPaintLayer*); 174 void updateDirectCompositingReasons(DeprecatedPaintLayer*);
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 // The root layer doesn't composite if it's a non-scrollable frame. 226 // The root layer doesn't composite if it's a non-scrollable frame.
224 // So, after a layout we set this dirty bit to know that we need 227 // So, after a layout we set this dirty bit to know that we need
225 // to recompute whether the root layer should composite even if 228 // to recompute whether the root layer should composite even if
226 // none of its descendants composite. 229 // none of its descendants composite.
227 // FIXME: Get rid of all the callers of setCompositingModeEnabled 230 // FIXME: Get rid of all the callers of setCompositingModeEnabled
228 // except the one in updateIfNeeded, then rename this to 231 // except the one in updateIfNeeded, then rename this to
229 // m_compositingDirty. 232 // m_compositingDirty.
230 bool m_rootShouldAlwaysCompositeDirty; 233 bool m_rootShouldAlwaysCompositeDirty;
231 bool m_needsUpdateFixedBackground; 234 bool m_needsUpdateFixedBackground;
232 bool m_isTrackingPaintInvalidations; // Used for testing. 235 bool m_isTrackingPaintInvalidations; // Used for testing.
236 bool m_inOverlayFullscreenVideo;
237 bool m_needsUpdateDescendantDependentFlags;
233 238
234 RootLayerAttachment m_rootLayerAttachment; 239 RootLayerAttachment m_rootLayerAttachment;
235 240
236 // Enclosing container layer, which clips for iframe content 241 // Enclosing container layer, which clips for iframe content
237 OwnPtr<GraphicsLayer> m_containerLayer; 242 OwnPtr<GraphicsLayer> m_containerLayer;
238 OwnPtr<GraphicsLayer> m_scrollLayer; 243 OwnPtr<GraphicsLayer> m_scrollLayer;
239 244
240 // Enclosing layer for overflow controls and the clipping layer 245 // Enclosing layer for overflow controls and the clipping layer
241 OwnPtr<GraphicsLayer> m_overflowControlsHostLayer; 246 OwnPtr<GraphicsLayer> m_overflowControlsHostLayer;
242 247
243 // Layers for overflow controls 248 // Layers for overflow controls
244 OwnPtr<GraphicsLayer> m_layerForHorizontalScrollbar; 249 OwnPtr<GraphicsLayer> m_layerForHorizontalScrollbar;
245 OwnPtr<GraphicsLayer> m_layerForVerticalScrollbar; 250 OwnPtr<GraphicsLayer> m_layerForVerticalScrollbar;
246 OwnPtr<GraphicsLayer> m_layerForScrollCorner; 251 OwnPtr<GraphicsLayer> m_layerForScrollCorner;
247
248 bool m_inOverlayFullscreenVideo;
249 }; 252 };
250 253
251 } // namespace blink 254 } // namespace blink
252 255
253 #endif // DeprecatedPaintLayerCompositor_h 256 #endif // DeprecatedPaintLayerCompositor_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/layout/compositing/DeprecatedPaintLayerCompositor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698