Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1149293007: Add a password field count histogram for empty usernames investigation. (Closed)

Created:
5 years, 6 months ago by msramek
Modified:
5 years, 6 months ago
Reviewers:
vasilii, Ilya Sherman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, vabr+watchlist_chromium.org, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org, vabr (Chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a password field count histogram for empty usernames investigation. We already have the histogram PasswordManager.EmptyUsernames.TextAndPasswordFieldCount which reports the total count of username and password fields, but to better understand it, it would help to also have a separate count of only password fields. BUG=456728 Committed: https://crrev.com/118baad5c78eb233c426336d996d4c546d6b057d Cr-Commit-Position: refs/heads/master@{#333249}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M components/autofill/content/renderer/password_form_conversion_utils.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
msramek
Hi Ilya and Vasilii, to the histogram that counts usernames and passwords in a password ...
5 years, 6 months ago (2015-06-03 11:47:33 UTC) #2
vasilii
lgtm
5 years, 6 months ago (2015-06-03 11:55:49 UTC) #3
Ilya Sherman
LGTM
5 years, 6 months ago (2015-06-03 22:41:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149293007/1
5 years, 6 months ago (2015-06-08 07:04:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-08 08:08:17 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 08:09:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/118baad5c78eb233c426336d996d4c546d6b057d
Cr-Commit-Position: refs/heads/master@{#333249}

Powered by Google App Engine
This is Rietveld 408576698