Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils.cc

Issue 1149293007: Add a password field count histogram for empty usernames investigation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/password_form_conversion_utils.cc
diff --git a/components/autofill/content/renderer/password_form_conversion_utils.cc b/components/autofill/content/renderer/password_form_conversion_utils.cc
index e27e482ac4b46aad2da8990eb99fa7e163402eda..f4dfcdf53f6f9e99323f0aa14430391c864485f7 100644
--- a/components/autofill/content/renderer/password_form_conversion_utils.cc
+++ b/components/autofill/content/renderer/password_form_conversion_utils.cc
@@ -427,6 +427,10 @@ void GetPasswordForm(
UMA_HISTOGRAM_COUNTS_100(
"PasswordManager.EmptyUsernames.TextAndPasswordFieldCount",
layout_sequence.size());
+ // For comparison, also report the number of password fields.
+ UMA_HISTOGRAM_COUNTS_100(
+ "PasswordManager.EmptyUsernames.PasswordFieldCount",
+ std::count(layout_sequence.begin(), layout_sequence.end(), 'P'));
}
password_form->scheme = PasswordForm::SCHEME_HTML;
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698