Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1149273003: Add workerReady timing for ServiceWorker controlled requests [1/3] (Closed)

Created:
5 years, 6 months ago by Kunihiko Sakamoto
Modified:
5 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, serviceworker-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add workerReady timing for ServiceWorker controlled requests [1/3] To make ServiceWorker startup time measureable, in addition to workerStart, we need another timing "workerReady" which is the point ServiceWorker finished starting and is ready to handle events. This essentially re-adds the "serviceWorkerFetchReady" value removed in crrev.com/1159663002. [1/3] THIS [2/3] https://codereview.chromium.org/1146253004/ [3/3] https://codereview.chromium.org/1166953007/ BUG=465640 TEST=all existing tests should pass Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196562

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M Source/platform/exported/WebURLLoadTiming.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/platform/network/ResourceLoadTiming.h View 6 chunks +6 lines, -0 lines 0 comments Download
M public/platform/WebURLLoadTiming.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Kunihiko Sakamoto
Kent-san, could you take a look?
5 years, 6 months ago (2015-06-05 07:49:12 UTC) #2
tkent
lgtm
5 years, 6 months ago (2015-06-05 07:55:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149273003/1
5 years, 6 months ago (2015-06-05 07:56:38 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 07:59:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196562

Powered by Google App Engine
This is Rietveld 408576698