Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1149243003: Returning scoped_ptr instead of raw pointer in QuicInfoToValue in net/ (Closed)

Created:
5 years, 7 months ago by payal.pandey
Modified:
5 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Returning scoped_ptr instead of raw pointer in QuicInfoToValue in net/ BUG=472381 Committed: https://crrev.com/a18956abbc96a3714625dacaef1ff1285acb6136 Cr-Commit-Position: refs/heads/master@{#331538}

Patch Set 1 #

Total comments: 9

Patch Set 2 : Incorporated review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M net/http/http_network_session.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_network_session.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/quic_client_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_client_session.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M net/quic/quic_stream_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_stream_factory.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
payal.pandey
Please have a look, Thanks.
5 years, 7 months ago (2015-05-25 11:39:48 UTC) #2
eroman
https://codereview.chromium.org/1149243003/diff/1/net/http/http_network_session.cc File net/http/http_network_session.cc (right): https://codereview.chromium.org/1149243003/diff/1/net/http/http_network_session.cc#newcode265 net/http/http_network_session.cc:265: quic_stream_factory_.QuicStreamFactoryInfoToValue().Pass()); Remove .Pass() https://codereview.chromium.org/1149243003/diff/1/net/http/http_network_session.h File net/http/http_network_session.h (right): https://codereview.chromium.org/1149243003/diff/1/net/http/http_network_session.h#newcode195 net/http/http_network_session.h:195: ...
5 years, 7 months ago (2015-05-25 17:48:56 UTC) #3
payal.pandey
Updated the CL as per review comments, Please have a look again, Thanks. https://codereview.chromium.org/1149243003/diff/1/net/http/http_network_session.cc File ...
5 years, 7 months ago (2015-05-26 06:24:15 UTC) #4
eroman
lgtm
5 years, 7 months ago (2015-05-26 17:16:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149243003/20001
5 years, 7 months ago (2015-05-27 04:51:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-27 05:58:03 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 05:58:51 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a18956abbc96a3714625dacaef1ff1285acb6136
Cr-Commit-Position: refs/heads/master@{#331538}

Powered by Google App Engine
This is Rietveld 408576698