Returning scoped_ptr instead of raw pointer in QuicInfoToValue in net/

net/http/http_network_session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_network_session.h"
 
 #include <utility>
 
 #include "base/compiler_specific.h"
 #include "base/debug/stack_trace.h"
@@ skipping 241 matching lines @@
 
 base::Value* HttpNetworkSession::SocketPoolInfoToValue() const {
   // TODO(yutak): Should merge values from normal pools and WebSocket pools.
   return normal_socket_pool_manager_->SocketPoolInfoToValue();
 }
 
 base::Value* HttpNetworkSession::SpdySessionPoolInfoToValue() const {
   return spdy_session_pool_.SpdySessionPoolInfoToValue();
 }
 
-base::Value* HttpNetworkSession::QuicInfoToValue() const {
+scoped_ptr<base::Value> HttpNetworkSession::QuicInfoToValue() const {
   scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
-  dict->Set("sessions", quic_stream_factory_.QuicStreamFactoryInfoToValue());
+  dict->Set("sessions",
+            quic_stream_factory_.QuicStreamFactoryInfoToValue().Pass());

[eroman, 2015/05/25 17:48:56]

Remove .Pass()

[payal.pandey, 2015/05/26 06:24:15]

Done.

   dict->SetBoolean("quic_enabled", params_.enable_quic);
   dict->SetBoolean("quic_enabled_for_proxies", params_.enable_quic_for_proxies);
   dict->SetBoolean("enable_quic_port_selection",
                    params_.enable_quic_port_selection);
-  base::ListValue* connection_options = new base::ListValue;
+  scoped_ptr<base::ListValue> connection_options(new base::ListValue);
   for (QuicTagVector::const_iterator it =
            params_.quic_connection_options.begin();
        it != params_.quic_connection_options.end(); ++it) {
     connection_options->AppendString("'" + QuicUtils::TagToString(*it) + "'");
   }
-  dict->Set("connection_options", connection_options);
+  dict->Set("connection_options", connection_options.Pass());
   dict->SetString("origin_to_force_quic_on",
                   params_.origin_to_force_quic_on.ToString());
   dict->SetDouble("alternative_service_probability_threshold",
                   params_.alternative_service_probability_threshold);
-  return dict.release();
+  return dict.Pass();
 }
 
 void HttpNetworkSession::CloseAllConnections() {
   normal_socket_pool_manager_->FlushSocketPoolsWithError(ERR_ABORTED);
   websocket_socket_pool_manager_->FlushSocketPoolsWithError(ERR_ABORTED);
   spdy_session_pool_.CloseCurrentSessions(ERR_ABORTED);
   quic_stream_factory_.CloseAllSessions(ERR_ABORTED);
 }
 
 void HttpNetworkSession::CloseIdleConnections() {
@@ skipping 30 matching lines @@
     case WEBSOCKET_SOCKET_POOL:
       return websocket_socket_pool_manager_.get();
     default:
       NOTREACHED();
       break;
   }
   return NULL;
 }
 
 }  // namespace net