Re-land: gpu: Add GL_TEXTURE_RECTANGLE_ARB support to CopyTexSubImage2D optimization of CopyTexture.

Re-land: gpu: Add GL_TEXTURE_RECTANGLE_ARB support to CopyTexSubImage2D optimization of CopyTexture.

The availability of this extension is already limited to desktop core
profile as the only reason we need to support it is IOSurfaces on
MacOSX.

This provides 2x performance improvement of copy operations when using
IOSurface backed GpuMemoryBuffers.

BUG=486922

[reveman, 2015-06-04 02:12:07]

reveman@chromium.org changed reviewers:
+ dongseong.hwang@chromium.org, piman@chromium.org

[dshwang, 2015-06-05 10:34:48]

dongseong.hwang@intel.com changed reviewers:
+ dongseong.hwang@intel.com
- dongseong.hwang@chromium.org

[dshwang, 2015-06-05 10:34:48]

GL_TEXTURE_RECTANGLE_ARB looks good.
However, I'm not sure CopyTex(Sub)Image can handle BGRA. I could not find
relevant spec about it in https://codereview.chromium.org/778123002

[reveman, 2015-06-05 15:33:55]

On 2015/06/05 at 10:34:48, dongseong.hwang wrote:
> GL_TEXTURE_RECTANGLE_ARB looks good.
> However, I'm not sure CopyTex(Sub)Image can handle BGRA. I could not find
relevant spec about it in https://codereview.chromium.org/778123002

Internal format doesn't matter in the glCopyTexSubImage2D case and
glCopyTexImage2D supports all formats supported by glTexImage2D afaict.

[dshwang, 2015-06-05 16:56:12]

On 2015/06/05 15:33:55, reveman wrote:
> On 2015/06/05 at 10:34:48, dongseong.hwang wrote:
> > GL_TEXTURE_RECTANGLE_ARB looks good.
> > However, I'm not sure CopyTex(Sub)Image can handle BGRA. I could not find
> relevant spec about it in https://codereview.chromium.org/778123002
> 
> Internal format doesn't matter in the glCopyTexSubImage2D case and
> glCopyTexImage2D supports all formats supported by glTexImage2D afaict.

thx for explaining. lgtm as non-owner.

[piman, 2015-06-05 21:11:47]

lgtm

[reveman, 2015-06-05 21:21:57]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2015-06-05 21:22:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1149233005/1

[commit-bot: I haz the power, 2015-06-05 22:38:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-06-05 22:39:34]

Patchset 1 (id:??) landed as
https://crrev.com/48514369cc66bc04ec766adf774de41d396a33ad
Cr-Commit-Position: refs/heads/master@{#333159}

[Ken Russell (switch to Gerrit), 2015-06-06 00:35:51]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1148853010/ by kbr@chromium.org.

The reason for reverting is: May have caused WebGL conformance test failures on
OS X; see http://crbug.com/486922 .
.

[dshwang, 2015-06-06 07:37:57]

On 2015/06/06 00:35:51, Ken Russell wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1148853010/ by mailto:kbr@chromium.org.
> 
> The reason for reverting is: May have caused WebGL conformance test failures
on
> OS X; see http://crbug.com/486922 .
> .

I guess it's because of BGRA copy.