Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 778123002: gpu: CopyTex(Sub)Image must not use BGRA internal format. (Closed)

Created:
6 years ago by dshwang
Modified:
6 years ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gpu: CopyTex(Sub)Image must not use BGRA internal format. The extensions that add BGRA support add it as a valid parameter for Tex(Sub)Image (EXT_texture_format_BGRA8888), and for ReadPixels (EXT_read_format_bgra), but not for CopyTex(Sub)Image. There's no support for copying from a BGRA buffer to a BGRA texture in any current extension. BUG=438691 Committed: https://crrev.com/21e9e82a9712755b36ddeaa72932c07c65e2553d Cr-Commit-Position: refs/heads/master@{#307220}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
dshwang
@sievers, Could you review? I realized that CopyTex(Sub)Image must not use BGRA when I try ...
6 years ago (2014-12-05 09:45:10 UTC) #2
no sievers
lgtm
6 years ago (2014-12-05 21:10:46 UTC) #3
dshwang
On 2014/12/05 21:10:46, sievers wrote: > lgtm Thank you for reviewing!
6 years ago (2014-12-08 10:07:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778123002/1
6 years ago (2014-12-08 10:08:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-08 10:45:44 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-08 10:47:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21e9e82a9712755b36ddeaa72932c07c65e2553d
Cr-Commit-Position: refs/heads/master@{#307220}

Powered by Google App Engine
This is Rietveld 408576698