Sky example game enhancements, adds preloading of images and adds transform modes to SpriteBox

Sky example game enhancements, adds preloading of images and adds transform modes to SpriteBox

R=eseidel@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/7167a95ecbd02a93decb497d4e5244094597bfad

[viktorl, 2015-06-03 20:00:17]

viktorl@google.com changed reviewers:
+ eseidel@chromium.org

[kulakowski, 2015-06-03 20:09:11]

kulakowski@chromium.org changed reviewers:
+ kulakowski@chromium.org

[kulakowski, 2015-06-03 20:09:12]

https://codereview.chromium.org/1149183004/diff/1/sky/examples/game/lib/image...
File sky/examples/game/lib/image_map.dart (right):

https://codereview.chromium.org/1149183004/diff/1/sky/examples/game/lib/image...
sky/examples/game/lib/image_map.dart:14: ImageMap(List<String> urls,
ImageMapCallback callback) {
Dart lets you directly assign into member variables in ctor signatures with the
following sugar:

ImageMap(List<String> urls, this._callback) {
   _images = new Map();
   _totalNumImages = urls.length;
   urls.forEach(_addURL);
 }

[eseidel, 2015-06-03 20:09:41]

Please fix your CL description (edit button on the website), since that will end
up as the commit message when you run git cl land.

[eseidel, 2015-06-03 20:11:10]

I don't have a lot of strogn opinions on this.  Looks like you're working with
george.  This is just an example.  Whatever you two work out is great.

https://codereview.chromium.org/1149183004/diff/1/sky/examples/game/lib/game_...
File sky/examples/game/lib/game_world.dart (right):

https://codereview.chromium.org/1149183004/diff/1/sky/examples/game/lib/game_...
sky/examples/game/lib/game_world.dart:10: this.width = 1024.0;
I'm surprised you want to make this hard-coded?  It's trivial to pass this in.
:p

[eseidel, 2015-06-03 21:49:35]

lgtm

[eseidel, 2015-06-03 21:49:46]

Please fix the CL description before landing.

[viktorl, 2015-06-03 22:06:00]

Committed patchset #2 (id:20001) manually as
7167a95ecbd02a93decb497d4e5244094597bfad (presubmit successful).