Issue 1149113005: Speed up shelldb by skipping unnecessary copies of APK to device

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1149113005: Speed up shelldb by skipping unnecessary copies of APK to device (Closed)

Created:
5 years, 7 months ago by jackson

Modified:
5 years, 7 months ago

Reviewers:
eseidel, Hixie

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Speed up shelldb by skipping unnecessary copies of APK to device Right now I'm storing a SHA1 in a folder in /sdcard since that seems likely to work on non-rooted devices, but I haven't tested it. This cuts build times from 6.5 seconds to 1.5 seconds for me. You can save another 0.5sec by passing the --no_install flag to avoid the SHA1 check altogether if you're sure that nothing has changed. R=eseidel@chromium.org, eseidel, hixie Committed: https://chromium.googlesource.com/external/mojo/+/6bf4f35647ed7deddd97d1cd3b52fd47754c34a3

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -2 lines)			Patch
	M	sky/tools/shelldb	View		3 chunks	+26 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jackson

5 years, 7 months ago (2015-05-27 00:51:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6bf4f35647ed7deddd97d1cd3b52fd47754c34a3 (presubmit successful).

Expand Messages | Collapse Messages