Speed up shelldb by skipping unnecessary copies of APK to device

sky/tools/shelldb

 #!/usr/bin/env python
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from skypy.skyserver import SkyServer
 import argparse
 import json
 import logging
 import os
 import re
 import signal
 import subprocess
 import sys
 import time
 import urlparse
+import hashlib
+import tempfile
 
 SKY_TOOLS_DIR = os.path.dirname(os.path.abspath(__file__))
 SKY_ROOT = os.path.dirname(SKY_TOOLS_DIR)
 SRC_ROOT = os.path.dirname(SKY_ROOT)
 
 SKY_SERVER_PORT = 9888
 OBSERVATORY_PORT = 8181
 DEFAULT_URL = "sky://domokit.github.io/sky_home"
 APK_NAME = 'SkyDemo.apk'
 ADB_PATH = os.path.join(SRC_ROOT,
     'third_party/android_tools/sdk/platform-tools/adb')
 ANDROID_PACKAGE = "org.domokit.sky.demo"
+SHA1_PATH = '/sdcard/%s/%s.sha1' % (ANDROID_PACKAGE, APK_NAME)
 
 PID_FILE_PATH = "/tmp/skydemo.pids"
 PID_FILE_KEYS = frozenset([
     'remote_sky_server_port',
     'sky_server_pid',
     'sky_server_port',
     'sky_server_root',
     'build_dir',
 ])
 
@@ skipping 147 matching lines @@
 
         packages_root = dev_packages_root(args.build_dir)
         sky_server = self._sky_server_for_args(args, packages_root)
         pids['sky_server_pid'] = sky_server.start()
         pids['sky_server_port'] = sky_server.port
         pids['sky_server_root'] = sky_server.root
 
         pids['build_dir'] = os.path.abspath(args.build_dir)
 
         if args.install:
-            # -r to replace an existing apk, -d to allow version downgrade.
-            subprocess.check_call([ADB_PATH, 'install', '-r', '-d', apk_path])
+            # We might need to install a new APK, so check SHA1
+            source_sha1 = hashlib.sha1(open(apk_path, 'rb').read()).hexdigest()
+            dest_sha1 = subprocess.check_output([ADB_PATH, 'shell', 'cat', SHA1_PATH])
+            use_existing_apk = False
+            if source_sha1 == dest_sha1:
+                # Make sure that the APK didn't get uninstalled somehow
+                use_existing_apk = subprocess.check_output([
+                    ADB_PATH, 'shell', 'pm', 'list', 'packages', ANDROID_PACKAGE
+                ])
         else:
+            # User is telling us not to bother installing an APK
+            use_existing_apk = True
+
+        if use_existing_apk:
+            # APK is already on the device, we only need to stop it
             subprocess.check_call([
                 ADB_PATH, 'shell', 'am', 'force-stop', ANDROID_PACKAGE
             ])
+        else:
+            # Slow path, need to upload a new APK to the device
+            # -r to replace an existing apk, -d to allow version downgrade.
+            subprocess.check_call([ADB_PATH, 'install', '-r', '-d', apk_path])
+            # record the SHA1 of the APK we just pushed
+            with tempfile.NamedTemporaryFile() as fp:
+                fp.write(source_sha1)
+                fp.seek(0)
+                subprocess.check_call([ADB_PATH, 'push', fp.name, SHA1_PATH])
 
         # Set up port forwarding for observatory
         port_string = 'tcp:%s' % OBSERVATORY_PORT
         subprocess.check_call([
             ADB_PATH, 'forward', port_string, port_string
         ])
 
         port_string = 'tcp:%s' % sky_server.port
         subprocess.check_call([
             ADB_PATH, 'reverse', port_string, port_string
@@ skipping 147 matching lines @@
         args = parser.parse_args()
         pids = Pids.read_from(PID_FILE_PATH, PID_FILE_KEYS)
         exit_code = args.func(args, pids)
         # We could do this with an at-exit handler instead?
         pids.write_to(PID_FILE_PATH)
         sys.exit(exit_code)
 
 
 if __name__ == '__main__':
     SkyShellRunner().main()