[Media Galleries] Introduce a new type for Mac Image Capture.

chrome/browser/system_monitor/disk_info_mac.h

Index: chrome/browser/system_monitor/disk_info_mac.h
diff --git a/chrome/browser/system_monitor/disk_info_mac.h b/chrome/browser/system_monitor/disk_info_mac.h
index 2c046489001dd7ba605a19e0e64e4b0d6f19f3f8..106c2c75647b91f1c6e32e41c466cabefd4417d8 100644
--- a/chrome/browser/system_monitor/disk_info_mac.h
+++ b/chrome/browser/system_monitor/disk_info_mac.h
@@ -22,6 +22,11 @@ class DiskInfoMac {
   // dictionary. This function must be called on the file thread.
   static DiskInfoMac BuildDiskInfoOnFileThread(CFDictionaryRef dict);
 
+  // Construct a disk info object from info from an ImageCature device.
+  static DiskInfoMac BuildDiskInfoFromICDevice(std::string device_id,

[sail, 2012/12/10 23:06:36]

exercise this in unit tests?

[Greg Billock, 2012/12/11 00:11:22]

I'll see about doing this later. I don't think a direct test of this will mean
much.

[sail, 2012/12/11 00:14:01]

Could you add a TODO? It would be good to have good test coverage even if all it
does it call the function and not assert anything.

[Greg Billock, 2012/12/11 01:02:26]

OK. I do think this'll get tested, but I don't think a test file for this method
alone is very valuable -- it'd essentially be a compiler test.

On 2012/12/11 00:14:01, sail wrote:

[sail, 2012/12/11 18:40:21]

The disk info stuff is exercised in
removable_device_notifications_mac_unittest.mm. No new file needed.

+                                               string16 device_name,
+                                               FilePath mount_point);
+
   const std::string& bsd_name() const { return bsd_name_; }
   const std::string& device_id() const { return device_id_; }
   const std::string& model_name() const { return model_name_; }