[Media Galleries] Introduce a new type for Mac Image Capture.

chrome/browser/system_monitor/disk_info_mac.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYSTEM_MONITOR_DISK_INFO_MAC_H_
 #define CHROME_BROWSER_SYSTEM_MONITOR_DISK_INFO_MAC_H_
 
 #include <CoreFoundation/CoreFoundation.h>
 
 #include "base/file_path.h"
 #include "chrome/browser/system_monitor/media_storage_util.h"
 
 namespace chrome {
 
 // This class stores information about a particular disk.
 class DiskInfoMac {
  public:
   DiskInfoMac();
   ~DiskInfoMac();
 
   // Creates a disk info object based on information from the given
   // dictionary. This function must be called on the file thread.
   static DiskInfoMac BuildDiskInfoOnFileThread(CFDictionaryRef dict);
 
+  // Construct a disk info object from info from an ImageCature device.
+  static DiskInfoMac BuildDiskInfoFromICDevice(std::string device_id,

[sail, 2012/12/10 23:06:36]

exercise this in unit tests?

[Greg Billock, 2012/12/11 00:11:22]

I'll see about doing this later. I don't think a direct test of this will mean
much.

[sail, 2012/12/11 00:14:01]

Could you add a TODO? It would be good to have good test coverage even if all it
does it call the function and not assert anything.

[Greg Billock, 2012/12/11 01:02:26]

OK. I do think this'll get tested, but I don't think a test file for this method
alone is very valuable -- it'd essentially be a compiler test.

On 2012/12/11 00:14:01, sail wrote:

[sail, 2012/12/11 18:40:21]

The disk info stuff is exercised in
removable_device_notifications_mac_unittest.mm. No new file needed.

+                                               string16 device_name,
+                                               FilePath mount_point);
+
   const std::string& bsd_name() const { return bsd_name_; }
   const std::string& device_id() const { return device_id_; }
   const std::string& model_name() const { return model_name_; }
   const string16& device_name() const { return device_name_; }
   const FilePath& mount_point() const { return mount_point_; }
   MediaStorageUtil::Type type() const { return type_; }
   uint64 total_size_in_bytes() const { return total_size_in_bytes_; }
 
  private:
   std::string bsd_name_;
   std::string device_id_;
   std::string model_name_;
   string16 device_name_;
   FilePath mount_point_;
   MediaStorageUtil::Type type_;
   uint64 total_size_in_bytes_;
 };
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_SYSTEM_MONITOR_DISK_INFO_MAC_H_