Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: content/test/test_frame_navigation_observer.h

Issue 1148953014: Fix the commit type for out-of-process iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix failing tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/test_frame_navigation_observer.h
diff --git a/content/test/test_frame_navigation_observer.h b/content/test/test_frame_navigation_observer.h
index 9ff42c53e858e059a1e87f19623b90f30fff74e4..6a57e48d78f9c82f86f8bf278e5aeeb06f59f58d 100644
--- a/content/test/test_frame_navigation_observer.h
+++ b/content/test/test_frame_navigation_observer.h
@@ -44,9 +44,10 @@ class TestFrameNavigationObserver : public WebContentsObserver {
const GURL& validated_url,
bool is_error_page,
bool is_iframe_srcdoc) override;
- void DidNavigateAnyFrame(RenderFrameHost* render_frame_host,
- const LoadCommittedDetails& details,
- const FrameNavigateParams& params) override;
+ void DidCommitProvisionalLoadForFrame(
Charlie Reis 2015/05/27 17:26:24 This is https://codereview.chromium.org/1149073004
+ RenderFrameHost* render_frame_host,
+ const GURL& url,
+ ui::PageTransition transition_type) override;
// The id of the FrameTreeNode in which navigations are peformed.
int frame_tree_node_id_;

Powered by Google App Engine
This is Rietveld 408576698