content/test/test_frame_navigation_observer.cc - Issue 1148953014: Fix the commit type for out-of-process iframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/test_frame_navigation_observer.cc

Issue 1148953014: Fix the commit type for out-of-process iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix failing tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/test/test_frame_navigation_observer.cc

diff --git a/content/test/test_frame_navigation_observer.cc b/content/test/test_frame_navigation_observer.cc

index c6d151bc2ee2360b4ef2e40d4628d8036d569034..39cfb85e97d70b6481d04199e11bc87626315d8f 100644

--- a/content/test/test_frame_navigation_observer.cc

+++ b/content/test/test_frame_navigation_observer.cc

@@ -58,10 +58,10 @@ void TestFrameNavigationObserver::DidStartProvisionalLoadForFrame(

navigation_started_ = true;

}

-void TestFrameNavigationObserver::DidNavigateAnyFrame(

+void TestFrameNavigationObserver::DidCommitProvisionalLoadForFrame(

RenderFrameHost* render_frame_host,

- const LoadCommittedDetails& details,

- const FrameNavigateParams& params) {

+ const GURL& url,

+ ui::PageTransition transition_type) {

if (!navigation_started_)

return;