Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2854)

Unified Diff: chrome/browser/chromeos/network_settings/onc_validator_unittest.cc

Issue 11488008: Adding more ONC validation tests. (Closed) Base URL: http://git.chromium.org/chromium/src.git@reject_network_independently
Patch Set: Initial patch. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/chromeos/network_settings/invalid_settings_with_repairs.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/network_settings/onc_validator_unittest.cc
diff --git a/chrome/browser/chromeos/network_settings/onc_validator_unittest.cc b/chrome/browser/chromeos/network_settings/onc_validator_unittest.cc
index 625518910c64e1edbcb3872bf6ef17919684c3e5..570477a16f84ded89444d3146ca7aaea30789807 100644
--- a/chrome/browser/chromeos/network_settings/onc_validator_unittest.cc
+++ b/chrome/browser/chromeos/network_settings/onc_validator_unittest.cc
@@ -116,7 +116,14 @@ TEST_P(ONCValidatorValidTest, LiberalValidationValid) {
INSTANTIATE_TEST_CASE_P(
ONCValidatorValidTest,
ONCValidatorValidTest,
- ::testing::Values(OncParams("managed_toplevel.onc",
+ ::testing::Values(OncParams("managed_toplevel1.onc",
+ &kToplevelConfigurationSignature,
+ true),
+ OncParams("managed_toplevel2.onc",
+ &kToplevelConfigurationSignature,
+ true),
+ // Test a configuration generated by CPanel.
+ OncParams("managed_toplevel_cpanel.onc",
&kToplevelConfigurationSignature,
true),
OncParams("encrypted.onc",
@@ -238,6 +245,16 @@ INSTANTIATE_TEST_CASE_P(
false),
RepairParams("network-repaired", "network-repaired"))));
+// Strict and liberal validator repair but differently.
Mattias Nissler (ping if slow) 2012/12/13 09:51:46 ... both repair, but with different results.
pneubeck (no reviews) 2012/12/13 14:33:02 Done.
+INSTANTIATE_TEST_CASE_P(
+ StrictAndLiberalRepairDifferently,
+ ONCValidatorTestRepairable,
+ ::testing::Values(
+ std::make_pair(OncParams("toplevel-with-nested-warning",
+ &kToplevelConfigurationSignature,
+ false),
+ RepairParams("toplevel-empty", "toplevel-repaired"))));
+
// Strict and liberal validator return both INVALID.
INSTANTIATE_TEST_CASE_P(
StrictAndLiberalInvalid,
« no previous file with comments | « no previous file | chrome/test/data/chromeos/network_settings/invalid_settings_with_repairs.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698