Adding more ONC validation tests.

chrome/browser/chromeos/network_settings/onc_validator_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/network_settings/onc_validator.h"
 
 #include <string>
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 98 matching lines @@
 TEST_P(ONCValidatorValidTest, LiberalValidationValid) {
   OncParams onc = GetParam();
   Validate(false, test_utils::ReadTestDictionary(onc.location), onc.signature,
            onc.is_managed);
   ExpectValid();
 }
 
 INSTANTIATE_TEST_CASE_P(
     ONCValidatorValidTest,
     ONCValidatorValidTest,
-    ::testing::Values(OncParams("managed_toplevel.onc",
+    ::testing::Values(OncParams("managed_toplevel1.onc",
+                                &kToplevelConfigurationSignature,
+                                true),
+                      OncParams("managed_toplevel2.onc",
+                                &kToplevelConfigurationSignature,
+                                true),
+                      // Test a configuration generated by CPanel.
+                      OncParams("managed_toplevel_cpanel.onc",
                                 &kToplevelConfigurationSignature,
                                 true),
                       OncParams("encrypted.onc",
                                 &kToplevelConfigurationSignature,
                                 true),
                       OncParams("managed_vpn.onc",
                                 &kNetworkConfigurationSignature,
                                 true),
                       OncParams("managed_ethernet.onc",
                                 &kNetworkConfigurationSignature,
@@ skipping 101 matching lines @@
                                   &kToplevelConfigurationSignature,
                                   true),
                         RepairParams("toplevel-repaired",
                                      "toplevel-repaired")),
          // Ignore recommended arrays in unmanaged ONC.
          std::make_pair(OncParams("network-with-illegal-recommended",
                                   &kNetworkConfigurationSignature,
                                   false),
                         RepairParams("network-repaired", "network-repaired"))));
 
+// Strict and liberal validator repair but differently.

[Mattias Nissler (ping if slow), 2012/12/13 09:51:46]

... both repair, but with different results.

[pneubeck (no reviews), 2012/12/13 14:33:02]

Done.

+INSTANTIATE_TEST_CASE_P(
+    StrictAndLiberalRepairDifferently,
+    ONCValidatorTestRepairable,
+    ::testing::Values(
+         std::make_pair(OncParams("toplevel-with-nested-warning",
+                                  &kToplevelConfigurationSignature,
+                                  false),
+                        RepairParams("toplevel-empty", "toplevel-repaired"))));
+
 // Strict and liberal validator return both INVALID.
 INSTANTIATE_TEST_CASE_P(
     StrictAndLiberalInvalid,
     ONCValidatorTestRepairable,
     ::testing::Values(
          std::make_pair(OncParams("network-unknown-value",
                                   &kNetworkConfigurationSignature, false),
                         RepairParams("", "")),
          std::make_pair(OncParams("managed-network-unknown-value",
                                   &kNetworkConfigurationSignature, true),
                         RepairParams("", "")),
          std::make_pair(OncParams("network-value-out-of-range",
                                   &kNetworkConfigurationSignature, false),
                         RepairParams("", "")),
          std::make_pair(OncParams("managed-network-value-out-of-range",
                                   &kNetworkConfigurationSignature, true),
                         RepairParams("", "")),
          std::make_pair(OncParams("network-wrong-type",
                                   &kNetworkConfigurationSignature, false),
                         RepairParams("", "")),
          std::make_pair(OncParams("managed-network-wrong-type",
                                   &kNetworkConfigurationSignature, true),
                         RepairParams("", ""))));
 
 }  // namespace onc
 }  // namespace chromeos