Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1148793002: Oilpan: disable VectorDestructorsWithVtable unit test with ASan. (Closed)

Created:
5 years, 7 months ago by sof
Modified:
5 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: disable VectorDestructorsWithVtable unit test with ASan. Testing behavior of inline capacity vectors when contiguous container support is enabled, is not worthwhile as they're disabled. (cf Vector.h:INLINE_CAPACITY.) R=haraken BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195615

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/platform/heap/HeapTest.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look.
5 years, 7 months ago (2015-05-20 10:05:38 UTC) #2
haraken
LGTM
5 years, 7 months ago (2015-05-20 12:29:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148793002/1
5 years, 7 months ago (2015-05-20 12:40:32 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 13:54:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195615

Powered by Google App Engine
This is Rietveld 408576698