Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1076)

Unified Diff: Source/platform/heap/HeapTest.cpp

Issue 1148793002: Oilpan: disable VectorDestructorsWithVtable unit test with ASan. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/HeapTest.cpp
diff --git a/Source/platform/heap/HeapTest.cpp b/Source/platform/heap/HeapTest.cpp
index 5cec26612de3c7f52abd1002be22431243fc11f4..43cdac954ba201375cb0beba71d22bf3ced94a16 100644
--- a/Source/platform/heap/HeapTest.cpp
+++ b/Source/platform/heap/HeapTest.cpp
@@ -4042,6 +4042,9 @@ TEST(HeapTest, VectorDestructors)
EXPECT_LE(8, InlinedVectorObject::s_destructorCalls);
}
+// TODO(Oilpan): when Vector.h's contiguous container support no longer disables
+// Vector<>s with inline capacity, enable this test.
+#if !defined(ANNOTATE_CONTIGUOUS_CONTAINER)
TEST(HeapTest, VectorDestructorsWithVtable)
{
clearOutOldGarbage();
@@ -4084,6 +4087,7 @@ TEST(HeapTest, VectorDestructorsWithVtable)
Heap::collectGarbage(ThreadState::NoHeapPointersOnStack, ThreadState::GCWithSweep, Heap::ForcedGC);
EXPECT_EQ(9, InlinedVectorObjectWithVtable::s_destructorCalls);
}
+#endif
template<typename Set>
void rawPtrInHashHelper()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698