Issue 1148713005: Add missing words done

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1148713005: Add missing words done

Created:
5 years, 7 months ago by JerseySlavek

Modified:
5 years, 6 months ago

Reviewers:
jerseyslavek, groby-ooo-7-16

CC:
chromium-reviews

Base URL:
http://src.chromium.org/svn/trunk/deps/third_party/hunspell_dictionaries

Target Ref:
refs/remotes/origin/master

Visibility:
Public.

More Reviews

Description

Add missing words done Most of missing words added to en_US dictionary and some REP rules to en_US.aff BUG=446077

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27990 lines, -395 lines)			Patch
	M	en_US.aff	View		2 chunks	+9 lines, -1 line	0 comments	Download
	M	en_US.dic_delta	View		1 chunk	+27981 lines, -394 lines	0 comments	Download

Messages

Total messages: 4 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

groby-ooo-7-16

5 years, 7 months ago (2015-05-23 00:29:58 UTC) #3

I'm sorry, but this is NOT LGTM

First, you need to sign the license agreement and add yourself to the AUTHORS
file - see https://www.chromium.org/developers/contributing-code

For the changes:

.aff changes need to happen upstream. Chromium does not support local changes to
these.

.dic_delta is supposed to hold _small_ changes and individual words that are not
already part of the main dictionary. A 27k addition is beyond the scope of that
file, and should be handled upstream. 

I'm sorry that I cannot approve this as-is :(

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages