Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1148673002: Add UseCounter for multiple createShadowRoot() for deprecation (Closed)

Created:
5 years, 7 months ago by kochi
Modified:
5 years, 7 months ago
Reviewers:
hayato
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Add UseCounter for multiple createShadowRoot() for deprecation BUG=489947 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195588

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix for review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M Source/core/dom/shadow/ElementShadow.cpp View 1 2 chunks +7 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
kochi
PTAL
5 years, 7 months ago (2015-05-20 01:49:04 UTC) #2
hayato
https://codereview.chromium.org/1148673002/diff/1/Source/core/dom/shadow/ElementShadow.cpp File Source/core/dom/shadow/ElementShadow.cpp (right): https://codereview.chromium.org/1148673002/diff/1/Source/core/dom/shadow/ElementShadow.cpp#newcode153 Source/core/dom/shadow/ElementShadow.cpp:153: else Will this count UserAgent ShadowRoot also? https://codereview.chromium.org/1148673002/diff/1/Source/core/frame/UseCounter.h File ...
5 years, 7 months ago (2015-05-20 02:10:04 UTC) #3
kochi
https://codereview.chromium.org/1148673002/diff/1/Source/core/dom/shadow/ElementShadow.cpp File Source/core/dom/shadow/ElementShadow.cpp (right): https://codereview.chromium.org/1148673002/diff/1/Source/core/dom/shadow/ElementShadow.cpp#newcode153 Source/core/dom/shadow/ElementShadow.cpp:153: else On 2015/05/20 02:10:04, hayato wrote: > Will this ...
5 years, 7 months ago (2015-05-20 02:26:25 UTC) #4
hayato
lgtm
5 years, 7 months ago (2015-05-20 05:12:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148673002/20001
5 years, 7 months ago (2015-05-20 05:12:45 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 06:21:55 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195588

Powered by Google App Engine
This is Rietveld 408576698