Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: Source/core/dom/shadow/ElementShadow.cpp

Issue 1148673002: Add UseCounter for multiple createShadowRoot() for deprecation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix for review Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Neither the name of Google Inc. nor the names of its 10 * * Neither the name of Google Inc. nor the names of its
(...skipping 13 matching lines...) Expand all
24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
25 */ 25 */
26 26
27 #include "config.h" 27 #include "config.h"
28 #include "core/dom/shadow/ElementShadow.h" 28 #include "core/dom/shadow/ElementShadow.h"
29 29
30 #include "core/css/StyleSheetList.h" 30 #include "core/css/StyleSheetList.h"
31 #include "core/dom/ElementTraversal.h" 31 #include "core/dom/ElementTraversal.h"
32 #include "core/dom/NodeTraversal.h" 32 #include "core/dom/NodeTraversal.h"
33 #include "core/dom/shadow/DistributedNodes.h" 33 #include "core/dom/shadow/DistributedNodes.h"
34 #include "core/frame/UseCounter.h"
34 #include "core/html/HTMLContentElement.h" 35 #include "core/html/HTMLContentElement.h"
35 #include "core/html/HTMLShadowElement.h" 36 #include "core/html/HTMLShadowElement.h"
36 #include "core/inspector/InspectorInstrumentation.h" 37 #include "core/inspector/InspectorInstrumentation.h"
37 #include "platform/EventDispatchForbiddenScope.h" 38 #include "platform/EventDispatchForbiddenScope.h"
38 #include "platform/ScriptForbiddenScope.h" 39 #include "platform/ScriptForbiddenScope.h"
39 40
40 namespace blink { 41 namespace blink {
41 42
42 class DistributionPool final { 43 class DistributionPool final {
43 STACK_ALLOCATED(); 44 STACK_ALLOCATED();
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 #if !ENABLE(OILPAN) 141 #if !ENABLE(OILPAN)
141 removeDetachedShadowRoots(); 142 removeDetachedShadowRoots();
142 #endif 143 #endif
143 } 144 }
144 145
145 ShadowRoot& ElementShadow::addShadowRoot(Element& shadowHost, ShadowRoot::Shadow RootType type) 146 ShadowRoot& ElementShadow::addShadowRoot(Element& shadowHost, ShadowRoot::Shadow RootType type)
146 { 147 {
147 EventDispatchForbiddenScope assertNoEventDispatch; 148 EventDispatchForbiddenScope assertNoEventDispatch;
148 ScriptForbiddenScope forbidScript; 149 ScriptForbiddenScope forbidScript;
149 150
150 if (type == ShadowRoot::OpenShadowRoot && (!youngestShadowRoot() || youngest ShadowRoot()->type() == ShadowRoot::UserAgentShadowRoot)) 151 if (type == ShadowRoot::OpenShadowRoot) {
151 shadowHost.willAddFirstOpenShadowRoot(); 152 if (!youngestShadowRoot() || youngestShadowRoot()->type() == ShadowRoot: :UserAgentShadowRoot)
153 shadowHost.willAddFirstOpenShadowRoot();
154 else
155 UseCounter::count(shadowHost.document(), UseCounter::ElementCreateSh adowRootMultiple);
156 }
152 157
153 for (ShadowRoot* root = youngestShadowRoot(); root; root = root->olderShadow Root()) 158 for (ShadowRoot* root = youngestShadowRoot(); root; root = root->olderShadow Root())
154 root->lazyReattachIfAttached(); 159 root->lazyReattachIfAttached();
155 160
156 RefPtrWillBeRawPtr<ShadowRoot> shadowRoot = ShadowRoot::create(shadowHost.do cument(), type); 161 RefPtrWillBeRawPtr<ShadowRoot> shadowRoot = ShadowRoot::create(shadowHost.do cument(), type);
157 shadowRoot->setParentOrShadowHostNode(&shadowHost); 162 shadowRoot->setParentOrShadowHostNode(&shadowHost);
158 shadowRoot->setParentTreeScope(shadowHost.treeScope()); 163 shadowRoot->setParentTreeScope(shadowHost.treeScope());
159 m_shadowRoots.push(shadowRoot.get()); 164 m_shadowRoots.push(shadowRoot.get());
160 setNeedsDistributionRecalc(); 165 setNeedsDistributionRecalc();
161 166
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 visitor->trace(m_nodeToInsertionPoints); 376 visitor->trace(m_nodeToInsertionPoints);
372 visitor->trace(m_selectFeatures); 377 visitor->trace(m_selectFeatures);
373 // Shadow roots are linked with previous and next pointers which are traced. 378 // Shadow roots are linked with previous and next pointers which are traced.
374 // It is therefore enough to trace one of the shadow roots here and the 379 // It is therefore enough to trace one of the shadow roots here and the
375 // rest will be traced from there. 380 // rest will be traced from there.
376 visitor->trace(m_shadowRoots.head()); 381 visitor->trace(m_shadowRoots.head());
377 #endif 382 #endif
378 } 383 }
379 384
380 } // namespace 385 } // namespace
OLDNEW
« no previous file with comments | « no previous file | Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698