msvs: Make sure stdout/stderr from rule commands get logged

msvs: Make sure stdout/stderr from rule commands get logged

By default, stdout and stderr from rule scripts are not printed in the msvs
console unless the user changes their MSBuild verbosity to "Detailed".
However, the "Detailed" setting prints way too much information, making it hard
to find the actual script output.

This commit makes it so that anything printed to stdout and stderr from rules
will be printed in the msvs console.  The EchoOff setting is used to prevent
the actual command from also being printed.

BUG=
R=scottmg@chromium.org

Committed: https://chromium.googlesource.com/external/gyp/+/aa537916dcb59ffd6c4ecabf77a119837a409649

[Shezan Baig (Bloomberg), 2015-05-28 09:33:25]

sbaig1@bloomberg.net changed reviewers:
+ scottmg@chromium.org

[Shezan Baig (Bloomberg), 2015-05-28 09:33:26]

This makes msvs behave more like ninja w.r.t logging output from scripts

[Shezan Baig (Bloomberg), 2015-05-28 10:13:47]

Hmm, "git try" doesn't seem to launch the try jobs.  Is there a new command?

$ git try
Results will be emailed to: sbaig1@bloomberg.net
Patch 'ruleStdout#847d' sent to try server: gyp-linux:, gyp-win64:, gyp-win32:,
gyp-mac:
$

[scottmg, 2015-05-28 15:18:51]

lgtm

https://codereview.chromium.org/1148653011/diff/1/test/msvs/rules_stdout_stde...
File test/msvs/rules_stdout_stderr/rule_stderr.py (right):

https://codereview.chromium.org/1148653011/diff/1/test/msvs/rules_stdout_stde...
test/msvs/rules_stdout_stderr/rule_stderr.py:7: print>>sys.stderr, "This will go
to stderr"
nit; space before >>

[scottmg, 2015-05-28 15:19:15]

scottmg@chromium.org changed reviewers:
+ bradnelson@chromium.org

[scottmg, 2015-05-28 15:19:56]

On 2015/05/28 10:13:47, Shezan Baig (Bloomberg) wrote:
> Hmm, "git try" doesn't seem to launch the try jobs.  Is there a new command?
> 
> $ git try
> Results will be emailed to: mailto:sbaig1@bloomberg.net
> Patch 'ruleStdout#847d' sent to try server: gyp-linux:, gyp-win64:,
gyp-win32:,
> gyp-mac:
> $

I'm not sure, I had this trouble on my last patch. Brad do you have any idea? I
tried `git cl try` also which looks like it's going to work, but the jobs never
seem to start.

[Dirk Pranke, 2015-05-28 16:52:50]

On 2015/05/28 15:19:56, scottmg wrote:
> On 2015/05/28 10:13:47, Shezan Baig (Bloomberg) wrote:
> > Hmm, "git try" doesn't seem to launch the try jobs.  Is there a new command?
> > 
> > $ git try
> > Results will be emailed to: mailto:sbaig1@bloomberg.net
> > Patch 'ruleStdout#847d' sent to try server: gyp-linux:, gyp-win64:,
> gyp-win32:,
> > gyp-mac:
> > $
> 
> I'm not sure, I had this trouble on my last patch. Brad do you have any idea?
I
> tried `git cl try` also which looks like it's going to work, but the jobs
never
> seem to start.

There are no try servers for gyp at the moment (the old bots were shut down, and
I haven't yet spun up new ones).

[Shezan Baig (Bloomberg), 2015-05-29 10:10:28]

I'm getting the following error when I do "git cl land":

    Writing objects: 100% (15/15), 2.35 KiB | 0 bytes/s, done.
    Total 15 (delta 9), reused 0 (delta 0)
    remote: Resolving deltas: 100% (9/9)
    remote: Processing changes: refs: 1, done    
    error: failed to push some refs to
'https://chromium.googlesource.com/external/gyp.git'
    Failed to push. If this persists, please file a bug.

Am I still permissioned to land gyp changes?  (I haven't tried since the switch
to git).

[Shezan Baig (Bloomberg), 2015-05-29 10:15:20]

The CQ bit was checked by sbaig1@bloomberg.net

[Shezan Baig (Bloomberg), 2015-05-29 10:15:21]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1148653011/#ps20001
(title: "Add space before >>")

[scottmg, 2015-05-29 16:00:31]

On 2015/05/29 10:10:28, Shezan Baig (Bloomberg) wrote:
> I'm getting the following error when I do "git cl land":
> 
>     Writing objects: 100% (15/15), 2.35 KiB | 0 bytes/s, done.
>     Total 15 (delta 9), reused 0 (delta 0)
>     remote: Resolving deltas: 100% (9/9)
>     remote: Processing changes: refs: 1, done    
>     error: failed to push some refs to
> 'https://chromium.googlesource.com/external/gyp.git'
>     Failed to push. If this persists, please file a bug.
> 
> Am I still permissioned to land gyp changes?  (I haven't tried since the
switch
> to git).

I don't know of any permission changes. You might need to follow the steps at
chromium.googlesource.com/ "Generate Password"? (do you remember if you've
landed anything since the git switch?)

[Shezan Baig (Bloomberg), 2015-05-31 10:16:02]

On 2015/05/29 16:00:31, scottmg wrote:
> On 2015/05/29 10:10:28, Shezan Baig (Bloomberg) wrote:
> > I'm getting the following error when I do "git cl land":
> > 
> >     Writing objects: 100% (15/15), 2.35 KiB | 0 bytes/s, done.
> >     Total 15 (delta 9), reused 0 (delta 0)
> >     remote: Resolving deltas: 100% (9/9)
> >     remote: Processing changes: refs: 1, done    
> >     error: failed to push some refs to
> > 'https://chromium.googlesource.com/external/gyp.git'
> >     Failed to push. If this persists, please file a bug.
> > 
> > Am I still permissioned to land gyp changes?  (I haven't tried since the
> switch
> > to git).
> 
> I don't know of any permission changes. You might need to follow the steps at
> chromium.googlesource.com/ "Generate Password"? (do you remember if you've
> landed anything since the git switch?)


Hmm, I've tried that page (several times), but it still doesn't seem to work.  I
don't think I've landed anything since the git switch (my last commit was Feb
10), so I suspect something changed in the permissions during the switch?

[Shezan Baig (Bloomberg), 2015-06-03 23:19:48]

Committed patchset #3 (id:40001) manually as
aa537916dcb59ffd6c4ecabf77a119837a409649 (presubmit successful).