pylib/gyp/generator/msvs.py - Issue 1148653011: msvs: Make sure stdout/stderr from rule commands get logged

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/generator/msvs.py

Issue 1148653011: msvs: Make sure stdout/stderr from rule commands get logged (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pylib/gyp/generator/msvs.py

diff --git a/pylib/gyp/generator/msvs.py b/pylib/gyp/generator/msvs.py

index eb1e17d5bff1da91cfc267fd692a6e0507f6a55d..1338790ef68f9cae0df435bd358452e8cb19edb8 100644

--- a/pylib/gyp/generator/msvs.py

+++ b/pylib/gyp/generator/msvs.py

@@ -2345,6 +2345,9 @@ def _GenerateMSBuildRuleTargetsFile(targets_path, msbuild_rules):

rule_name,

{'Condition': "'@(%s)' != '' and '%%(%s.ExcludedFromBuild)' != "

"'true'" % (rule_name, rule_name),

+ 'EchoOff': 'true',

+ 'StandardOutputImportance': 'High',

+ 'StandardErrorImportance': 'High',

'CommandLineTemplate': '%%(%s.CommandLineTemplate)' % rule_name,

'AdditionalOptions': '%%(%s.AdditionalOptions)' % rule_name,

'Inputs': rule_inputs

« no previous file with comments | « no previous file | test/msvs/rules_stdout_stderr/dummy.bar » ('j') | no next file with comments »