chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc - Issue 1148383003: Only support seeking file streams from the beginning of the file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

Issue 1148383003: Only support seeking file streams from the beginning of the file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Win DBG build by Pass()-ing file out of CreateForAsyncHandle. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/drive/local_file_reader.cc ('k') | chrome/browser/extensions/api/messaging/native_process_launcher_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

diff --git a/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc b/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

index db03d507316fcf30a0ea7177f2e1e39697a16883..e8fa3f317d61a7bdfe34a08f7b09230304809799 100644

--- a/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

+++ b/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

@@ -201,13 +201,13 @@ TEST_F(NativeMessagingTest, SingleSendMessageWrite) {

#if defined(OS_WIN)

base::string16 pipe_name = base::StringPrintf(

L"\\\\.\\pipe\\chrome.nativeMessaging.out.%llx", base::RandUint64());

- base::File write_handle(

+ base::File write_handle = base::File::CreateForAsyncHandle(

CreateNamedPipeW(pipe_name.c_str(),

PIPE_ACCESS_OUTBOUND | FILE_FLAG_OVERLAPPED |

FILE_FLAG_FIRST_PIPE_INSTANCE,

PIPE_TYPE_BYTE, 1, 0, 0, 5000, NULL));

ASSERT_TRUE(write_handle.IsValid());

- base::File read_handle(

+ base::File read_handle = base::File::CreateForAsyncHandle(

CreateFileW(pipe_name.c_str(), GENERIC_READ, 0, NULL, OPEN_EXISTING,

FILE_ATTRIBUTE_NORMAL | FILE_FLAG_OVERLAPPED, NULL));

ASSERT_TRUE(read_handle.IsValid());