chrome/browser/extensions/api/messaging/native_process_launcher_win.cc - Issue 1148383003: Only support seeking file streams from the beginning of the file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_process_launcher_win.cc

Issue 1148383003: Only support seeking file streams from the beginning of the file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Win DBG build by Pass()-ing file out of CreateForAsyncHandle. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc ('k') | content/browser/android/url_request_content_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_process_launcher_win.cc

diff --git a/chrome/browser/extensions/api/messaging/native_process_launcher_win.cc b/chrome/browser/extensions/api/messaging/native_process_launcher_win.cc

index 367aeb14054f84649963ea6af55fcea545e46756..fa01111b2e677d2a11f7e41ed5a083d6ed365b32 100644

--- a/chrome/browser/extensions/api/messaging/native_process_launcher_win.cc

+++ b/chrome/browser/extensions/api/messaging/native_process_launcher_win.cc

@@ -170,8 +170,8 @@ bool NativeProcessLauncher::LaunchNativeProcess(

}

*process = cmd_process.Pass();

- *read_file = base::File(stdout_pipe.Take());

- *write_file = base::File(stdin_pipe.Take());

+ *read_file = base::File::CreateForAsyncHandle(stdout_pipe.Take());

+ *write_file = base::File::CreateForAsyncHandle(stdin_pipe.Take());

return true;

}