pkg/compiler/lib/src/mirrors/dart2js_member_mirrors.dart - Issue 1148343004: Remove ConstantExpression.value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/mirrors/dart2js_member_mirrors.dart

Issue 1148343004: Remove ConstantExpression.value (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Update comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/mirrors/dart2js_member_mirrors.dart

diff --git a/pkg/compiler/lib/src/mirrors/dart2js_member_mirrors.dart b/pkg/compiler/lib/src/mirrors/dart2js_member_mirrors.dart

index f2e3c7cb02317d3dc15f1644b6e971bf3c2ff985..bd510c245cad546799a7f36da6c2d73587457545 100644

--- a/pkg/compiler/lib/src/mirrors/dart2js_member_mirrors.dart

+++ b/pkg/compiler/lib/src/mirrors/dart2js_member_mirrors.dart

@@ -204,7 +204,7 @@ class Dart2JsParameterMirror extends Dart2JsMemberMirror

message: "Missing constant for parameter "

"$parameter with default value."));

return _convertConstantToInstanceMirror(mirrorSystem,

- constant, constant.value);

+ constant, mirrorSystem.compiler.constants.getConstantValue(constant));

}

return null;

}