Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1148333002: cc: Make re-added animations get pushed to the compositor thread (Closed)

Created:
5 years, 7 months ago by ajuma
Modified:
5 years, 7 months ago
Reviewers:
Ian Vollick
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Make re-added animations get pushed to the compositor thread When a layer with an animation is removed from the tree but later re-added (this can happen, for example, when an iframe containing an animation is set to display:none and later set back to display:block), the animation should continue. Currently, the animation is prevented from getting re-pushed to the compositor thread since it already has a start time. This logic used to be needed to prevent incorrectly re-pushing an animation that had already been deleted on the compositor thread, but is no longer needed for that purpose since we now always delete animations on the main thread before deleting them on the compositor thread. This CL removes this logic. BUG=409649 Committed: https://crrev.com/04063aa44f0b20829ae07663da96eba19ebe8f38 Cr-Commit-Position: refs/heads/master@{#330938}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -19 lines) Patch
M cc/animation/layer_animation_controller.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M cc/animation/layer_animation_controller_unittest.cc View 2 chunks +20 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 1 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ajuma
5 years, 7 months ago (2015-05-21 13:06:46 UTC) #2
Ian Vollick
On 2015/05/21 at 13:06:46, ajuma wrote: > nice! lgtm.
5 years, 7 months ago (2015-05-21 14:25:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148333002/20001
5 years, 7 months ago (2015-05-21 14:27:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-21 14:30:52 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 14:31:40 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04063aa44f0b20829ae07663da96eba19ebe8f38
Cr-Commit-Position: refs/heads/master@{#330938}

Powered by Google App Engine
This is Rietveld 408576698