[Extensions] Introduce a ScopedExtensionDialogAutoConfirm

[Extensions] Introduce a ScopedExtensionDialogAutoConfirm

Introduce a ScopedExtensionDialogAutoConfirm to use in place of the
ExtensionUninstallDialog::ScopedAutoConfirm and the unscoped
ExtensionInstallPrompt::g_auto_confirm_for_testing. Also use this in the
management api instead of it's g_auto_confirm_for_testing.

TBRs for small mechanical changes.
TBR=atwilson@chromium.org (c/b/policy)
TBR=pkasting@chromium.org (c/b/infobars)

Committed: https://crrev.com/6620949b513cc77e5cccf3b322a8b55a26bf731b
Cr-Commit-Position: refs/heads/master@{#333794}

[Devlin, 2015-05-29 15:22:10]

Patchset #1 (id:1) has been deleted

[Devlin, 2015-05-29 15:22:16]

Patchset #1 (id:20001) has been deleted

[Devlin, 2015-05-29 15:29:19]

rdevlin.cronin@chromium.org changed reviewers:
+ kalman@chromium.org

[Devlin, 2015-05-29 15:29:20]

Cleanup part 2!

https://codereview.chromium.org/1148323007/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/management/management_api_browsertest.cc
(left):

https://codereview.chromium.org/1148323007/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/management/management_api_browsertest.cc:113:
UninstallWithConfirmDialog) {
This test is fully covered by the similar unittest, and obviously unittest >
browsertest.

https://codereview.chromium.org/1148323007/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/management/management_api_unittest.cc (left):

https://codereview.chromium.org/1148323007/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/management/management_api_unittest.cc:172:
service()->AddExtension(extension.get());
This is a combination of Rietveld being silly and git cl format.  Nothing really
changed here except the scoped auto confirm.

https://codereview.chromium.org/1148323007/diff/40001/extensions/browser/api/...
File extensions/browser/api/management/management_api.cc (left):

https://codereview.chromium.org/1148323007/diff/40001/extensions/browser/api/...
extensions/browser/api/management/management_api.cc:544: switch
(auto_confirm_for_test) {
Woo!  Die, silly code, die!!

[not at google - send to devlin, 2015-05-30 01:13:28]

https://codereview.chromium.org/1148323007/diff/40001/extensions/browser/exte...
File extensions/browser/extension_dialog_auto_confirm.h (right):

https://codereview.chromium.org/1148323007/diff/40001/extensions/browser/exte...
extensions/browser/extension_dialog_auto_confirm.h:20: using
ScopedExtensionDialogAutoConfirm =
it seems like the "Extension" (and above) at least is a tautology, and you can
leave it out. A little less verbose.

https://codereview.chromium.org/1148323007/diff/40001/extensions/browser/exte...
extensions/browser/extension_dialog_auto_confirm.h:27: extern
ExtensionDialogAutoConfirm g_auto_confirm_install_for_testing;
I don't find the callsites of these particularly attractive;
ScopedDialogAutoConfirm(&g_auto_confirm_uninstall_for_testing, foo) would read
better as ScopedDialogAutoConfirmUninstall.

Then again, maybe I'd just have a single autoconfirm flag rather than trying to
separate install vs uninstall. In theory this is just going to grow if you need
to add other autoconfirm types (permission upgrade?) and I don't think the
distinction is that interesting. Especially even given that "uninstall" covers
two completely different code paths for uninstall.

I'd go with just "ScopedAutoConfirmDialogForTest" and
"IsAutoConfirmDialogForTest"?

[Devlin, 2015-06-01 18:13:13]

Renamed

[not at google - send to devlin, 2015-06-02 08:20:09]

lgtm

https://codereview.chromium.org/1148323007/diff/60001/chrome/browser/extensio...
File chrome/browser/extensions/unpacked_installer.cc (right):

https://codereview.chromium.org/1148323007/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/unpacked_installer.cc:94: InstallUIAbort(false);
could you add a break here?

https://codereview.chromium.org/1148323007/diff/60001/extensions/browser/api/...
File extensions/browser/api/management/management_api.cc (right):

https://codereview.chromium.org/1148323007/diff/60001/extensions/browser/api/...
extensions/browser/api/management/management_api.cc:549: // any way imply that
this actually creates a dialog and runs it.
I'm not actually sure what this TODO means, but cool!

[Devlin, 2015-06-03 22:07:15]

Patchset #4 (id:100001) has been deleted

[Devlin, 2015-06-10 20:35:13]

https://codereview.chromium.org/1148323007/diff/60001/chrome/browser/extensio...
File chrome/browser/extensions/unpacked_installer.cc (right):

https://codereview.chromium.org/1148323007/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/unpacked_installer.cc:94: InstallUIAbort(false);
On 2015/06/02 08:20:09, kalman wrote:
> could you add a break here?

Why not.

https://codereview.chromium.org/1148323007/diff/60001/extensions/browser/api/...
File extensions/browser/api/management/management_api.cc (right):

https://codereview.chromium.org/1148323007/diff/60001/extensions/browser/api/...
extensions/browser/api/management/management_api.cc:549: // any way imply that
this actually creates a dialog and runs it.
On 2015/06/02 08:20:09, kalman wrote:
> I'm not actually sure what this TODO means, but cool!

It means that calling "UninstallFunctionDelegate()" doesn't really imply that
what this is doing is showing an uninstall dialog.  It should be something like,
well, "ShowExtensionUninstallDialog()".  But this is how it was for awhile. 
Will be fixed in the next patch. :)

[Devlin, 2015-06-10 20:35:48]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-06-10 20:35:48]

The patchset sent to the CQ was uploaded after l-g-t-m from kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1148323007/#ps180001
(title: "Latest master")

[commit-bot: I haz the power, 2015-06-10 20:36:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1148323007/180001

[commit-bot: I haz the power, 2015-06-10 20:44:13]

Committed patchset #7 (id:180001)

[commit-bot: I haz the power, 2015-06-10 20:45:55]

Patchset 7 (id:??) landed as
https://crrev.com/6620949b513cc77e5cccf3b322a8b55a26bf731b
Cr-Commit-Position: refs/heads/master@{#333794}