[Extensions] Introduce a ScopedExtensionDialogAutoConfirm

chrome/browser/extensions/api/management/management_api_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_function_test_utils.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_service_test_base.h"
 #include "chrome/browser/extensions/test_extension_system.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/host_desktop.h"
 #include "chrome/test/base/test_browser_window.h"
 #include "extensions/browser/api/management/management_api.h"
 #include "extensions/browser/api/management/management_api_constants.h"
+#include "extensions/browser/extension_dialog_auto_confirm.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/management_policy.h"
 #include "extensions/browser/test_management_policy.h"
 #include "extensions/common/error_utils.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_set.h"
 #include "extensions/common/test_util.h"
 
@@ skipping 118 matching lines @@
   // We need to be on the UI thread for this.
   ResetThreadBundle(content::TestBrowserThreadBundle::DEFAULT);
   scoped_refptr<const Extension> extension = test_util::CreateEmptyExtension();
   service()->AddExtension(extension.get());
   std::string extension_id = extension->id();
 
   base::ListValue uninstall_args;
   uninstall_args.AppendString(extension->id());
 
   // Auto-accept any uninstalls.
-  ManagementUninstallFunctionBase::SetAutoConfirmForTest(true);
+  {
+    ScopedExtensionDialogAutoConfirm auto_confirm(
+        &g_auto_confirm_uninstall_for_testing, AUTO_CONFIRM_ACCEPT);
 
-  // Uninstall requires a user gesture, so this should fail.
-  scoped_refptr<UIThreadExtensionFunction> function(
-      new ManagementUninstallFunction());
-  EXPECT_FALSE(RunFunction(function, uninstall_args));
-  EXPECT_EQ(std::string(constants::kGestureNeededForUninstallError),
-            function->GetError());
+    // Uninstall requires a user gesture, so this should fail.
+    scoped_refptr<UIThreadExtensionFunction> function(
+        new ManagementUninstallFunction());
+    EXPECT_FALSE(RunFunction(function, uninstall_args));
+    EXPECT_EQ(std::string(constants::kGestureNeededForUninstallError),
+              function->GetError());
 
-  ExtensionFunction::ScopedUserGestureForTests scoped_user_gesture;
+    ExtensionFunction::ScopedUserGestureForTests scoped_user_gesture;
 
-  function = new ManagementUninstallFunction();
-  EXPECT_TRUE(registry()->enabled_extensions().Contains(extension_id));
-  EXPECT_TRUE(RunFunction(function, uninstall_args)) << function->GetError();
-  // The extension should be uninstalled.
-  EXPECT_FALSE(registry()->GetExtensionById(
-      extension_id, ExtensionRegistry::EVERYTHING));
+    function = new ManagementUninstallFunction();
+    EXPECT_TRUE(registry()->enabled_extensions().Contains(extension_id));
+    EXPECT_TRUE(RunFunction(function, uninstall_args)) << function->GetError();
+    // The extension should be uninstalled.
+    EXPECT_FALSE(registry()->GetExtensionById(extension_id,
+                                              ExtensionRegistry::EVERYTHING));
+  }
 
   // Install the extension again, and try uninstalling, auto-canceling the
   // dialog.
-  service()->AddExtension(extension.get());

[Devlin, 2015/05/29 15:29:20]

This is a combination of Rietveld being silly and git cl format.  Nothing really
changed here except the scoped auto confirm.

-  function = new ManagementUninstallFunction();
-  ManagementUninstallFunctionBase::SetAutoConfirmForTest(false);
-  EXPECT_TRUE(registry()->enabled_extensions().Contains(extension_id));
-  EXPECT_FALSE(RunFunction(function, uninstall_args));
-  // The uninstall should have failed.
-  EXPECT_TRUE(registry()->enabled_extensions().Contains(extension_id));
-  EXPECT_EQ(ErrorUtils::FormatErrorMessage(constants::kUninstallCanceledError,
-                                           extension_id),
-            function->GetError());
+  {
+    ScopedExtensionDialogAutoConfirm auto_confirm(
+        &g_auto_confirm_uninstall_for_testing, AUTO_CONFIRM_CANCEL);
+    ExtensionFunction::ScopedUserGestureForTests scoped_user_gesture;
 
-  // Try again, using showConfirmDialog: false.
-  scoped_ptr<base::DictionaryValue> options(new base::DictionaryValue());
-  options->SetBoolean("showConfirmDialog", false);
-  uninstall_args.Append(options.release());
-  function = new ManagementUninstallFunction();
-  EXPECT_TRUE(registry()->enabled_extensions().Contains(extension_id));
-  EXPECT_FALSE(RunFunction(function, uninstall_args));
-  // This should still fail, since extensions can only suppress the dialog for
-  // uninstalling themselves.
-  EXPECT_TRUE(registry()->enabled_extensions().Contains(extension_id));
-  EXPECT_EQ(ErrorUtils::FormatErrorMessage(constants::kUninstallCanceledError,
-                                           extension_id),
-            function->GetError());
+    service()->AddExtension(extension.get());
+    scoped_refptr<UIThreadExtensionFunction> function =
+        new ManagementUninstallFunction();
+    EXPECT_TRUE(registry()->enabled_extensions().Contains(extension_id));
+    EXPECT_FALSE(RunFunction(function, uninstall_args));
+    // The uninstall should have failed.
+    EXPECT_TRUE(registry()->enabled_extensions().Contains(extension_id));
+    EXPECT_EQ(ErrorUtils::FormatErrorMessage(constants::kUninstallCanceledError,
+                                             extension_id),
+              function->GetError());
 
-  // If we try uninstall the extension itself, the uninstall should succeed
-  // (even though we auto-cancel any dialog), because the dialog is never shown.
-  uninstall_args.Remove(0u, nullptr);
-  function = new ManagementUninstallSelfFunction();
-  function->set_extension(extension);
-  EXPECT_TRUE(registry()->enabled_extensions().Contains(extension_id));
-  EXPECT_TRUE(RunFunction(function, uninstall_args)) << function->GetError();
-  EXPECT_FALSE(registry()->GetExtensionById(
-      extension_id, ExtensionRegistry::EVERYTHING));
+    // Try again, using showConfirmDialog: false.
+    scoped_ptr<base::DictionaryValue> options(new base::DictionaryValue());
+    options->SetBoolean("showConfirmDialog", false);
+    uninstall_args.Append(options.release());
+    function = new ManagementUninstallFunction();
+    EXPECT_TRUE(registry()->enabled_extensions().Contains(extension_id));
+    EXPECT_FALSE(RunFunction(function, uninstall_args));
+    // This should still fail, since extensions can only suppress the dialog for
+    // uninstalling themselves.
+    EXPECT_TRUE(registry()->enabled_extensions().Contains(extension_id));
+    EXPECT_EQ(ErrorUtils::FormatErrorMessage(constants::kUninstallCanceledError,
+                                             extension_id),
+              function->GetError());
+
+    // If we try uninstall the extension itself, the uninstall should succeed
+    // (even though we auto-cancel any dialog), because the dialog is never
+    // shown.
+    uninstall_args.Remove(0u, nullptr);
+    function = new ManagementUninstallSelfFunction();
+    function->set_extension(extension);
+    EXPECT_TRUE(registry()->enabled_extensions().Contains(extension_id));
+    EXPECT_TRUE(RunFunction(function, uninstall_args)) << function->GetError();
+    EXPECT_FALSE(registry()->GetExtensionById(extension_id,
+                                              ExtensionRegistry::EVERYTHING));
+  }
 }
 
 }  // namespace extensions