Add histograms to entire MergeSession flow.

Add histograms to entire MergeSession flow.

This is part of refactoring ChromeOS to use the GaiaCookieManagerService

BUG=483594
Committed: https://crrev.com/270beb98f3c243245efcc72dc9c4b9ce70befa3a
Cr-Commit-Position: refs/heads/master@{#331579}

[Mike Lerman, 2015-05-21 18:19:52]

mlerman@chromium.org changed reviewers:
+ rogerta@chromium.org, xiyuan@chromium.org

[Mike Lerman, 2015-05-21 18:19:52]

Hi Roger, Xiyuan,

This CL re-adds the metrics that were removed from the OAuth2LoginVerifier.
Please review.

Thanks,
Mike

[xiyuan, 2015-05-21 19:35:34]

LGTM

Thank you for filling it up again.

https://codereview.chromium.org/1148283005/diff/40001/components/signin/core/...
File components/signin/core/browser/gaia_cookie_manager_service_unittest.cc
(right):

https://codereview.chromium.org/1148283005/diff/40001/components/signin/core/...
components/signin/core/browser/gaia_cookie_manager_service_unittest.cc:197:
GoogleServiceAuthError::SERVICE_ERROR, 1);
nit: indent 2 more space

https://codereview.chromium.org/1148283005/diff/40001/components/signin/core/...
components/signin/core/browser/gaia_cookie_manager_service_unittest.cc:263:
GoogleServiceAuthError::REQUEST_CANCELED, 2);
ditto

[Mike Lerman, 2015-05-21 20:46:05]

thanks Xiyuan.

https://codereview.chromium.org/1148283005/diff/40001/components/signin/core/...
File components/signin/core/browser/gaia_cookie_manager_service_unittest.cc
(right):

https://codereview.chromium.org/1148283005/diff/40001/components/signin/core/...
components/signin/core/browser/gaia_cookie_manager_service_unittest.cc:197:
GoogleServiceAuthError::SERVICE_ERROR, 1);
On 2015/05/21 19:35:34, xiyuan wrote:
> nit: indent 2 more space

Done.

https://codereview.chromium.org/1148283005/diff/40001/components/signin/core/...
components/signin/core/browser/gaia_cookie_manager_service_unittest.cc:263:
GoogleServiceAuthError::REQUEST_CANCELED, 2);
On 2015/05/21 19:35:34, xiyuan wrote:
> ditto

Done.

[Roger Tawa OOO till Jul 10th, 2015-05-26 15:59:58]

lgtm

[Mike Lerman, 2015-05-26 16:02:13]

The CQ bit was checked by mlerman@chromium.org

[Mike Lerman, 2015-05-26 16:02:13]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/1148283005/#ps60001
(title: "__indent")

[Mike Lerman, 2015-05-26 16:02:15]

The CQ bit was unchecked by mlerman@chromium.org

[Mike Lerman, 2015-05-26 16:43:19]

mlerman@chromium.org changed reviewers:
+ jwd@chromium.org

[Mike Lerman, 2015-05-26 16:43:19]

Hi Jesse, some histograms for you, please!

[jwd, 2015-05-27 13:52:43]

lgtm

https://codereview.chromium.org/1148283005/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1148283005/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:25573: +    This data is now included in
Signin.ListAccountsFailure.
Can you put the replacement histogram in the obsolete message please.

https://codereview.chromium.org/1148283005/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:37232: +    Failure reason to acquiring
an ubertoken based on an already-minted access
Nit: Maybe, Reason of failure to..

[jwd, 2015-05-27 13:52:43]

lgtm

lgtm

https://codereview.chromium.org/1148283005/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1148283005/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:25573: +    This data is now included in
Signin.ListAccountsFailure.
Can you put the replacement histogram in the obsolete message please.

https://codereview.chromium.org/1148283005/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:37232: +    Failure reason to acquiring
an ubertoken based on an already-minted access
Nit: Maybe, Reason of failure to..

[Mike Lerman, 2015-05-27 13:59:51]

Thanks Jesse.

https://codereview.chromium.org/1148283005/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1148283005/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:25573: +    This data is now included in
Signin.ListAccountsFailure.
On 2015/05/27 13:52:43, Jesse Doherty (OOO may 9-24) wrote:
> Can you put the replacement histogram in the obsolete message please.

Done.

https://codereview.chromium.org/1148283005/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:37232: +    Failure reason to acquiring
an ubertoken based on an already-minted access
On 2015/05/27 13:52:43, Jesse Doherty (OOO may 9-24) wrote:
> Nit: Maybe, Reason of failure to.. 

Done.

[Mike Lerman, 2015-05-27 14:44:57]

The CQ bit was checked by mlerman@chromium.org

[Mike Lerman, 2015-05-27 14:44:58]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
rogerta@chromium.org, jwd@chromium.org
Link to the patchset: https://codereview.chromium.org/1148283005/#ps80001
(title: "jwd comments")

[commit-bot: I haz the power, 2015-05-27 14:45:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1148283005/80001

[commit-bot: I haz the power, 2015-05-27 15:51:01]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-27 15:51:55]

Patchset 5 (id:??) landed as
https://crrev.com/270beb98f3c243245efcc72dc9c4b9ce70befa3a
Cr-Commit-Position: refs/heads/master@{#331579}