Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8489)

Unified Diff: components/signin/core/browser/gaia_cookie_manager_service_unittest.cc

Issue 1148283005: Add histograms to entire MergeSession flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: jwd comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/gaia_cookie_manager_service_unittest.cc
diff --git a/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc b/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc
index 4975e81cdfc0ce390bcfc07a30f09950be606258..53b95835b2f59063568fb863e0cd0579faf47392 100644
--- a/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc
+++ b/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc
@@ -10,6 +10,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/message_loop/message_loop.h"
#include "base/strings/stringprintf.h"
+#include "base/test/histogram_tester.h"
#include "components/signin/core/browser/gaia_cookie_manager_service.h"
#include "components/signin/core/browser/test_signin_client.h"
#include "google_apis/gaia/fake_oauth2_token_service.h"
@@ -182,6 +183,7 @@ TEST_F(GaiaCookieManagerServiceTest, Success) {
TEST_F(GaiaCookieManagerServiceTest, FailedMergeSession) {
InstrumentedGaiaCookieManagerService helper(token_service(), signin_client());
MockObserver observer(&helper);
+ base::HistogramTester histograms;
EXPECT_CALL(helper, StartFetchingUbertoken());
EXPECT_CALL(observer, OnAddAccountToCookieCompleted("acc1@gmail.com",
@@ -191,6 +193,8 @@ TEST_F(GaiaCookieManagerServiceTest, FailedMergeSession) {
SimulateMergeSessionFailure(&helper, error());
// Persistent error incurs no further retries.
DCHECK(!helper.is_running());
+ histograms.ExpectUniqueSample("OAuth2Login.MergeSessionFailure",
+ GoogleServiceAuthError::SERVICE_ERROR, 1);
}
TEST_F(GaiaCookieManagerServiceTest, AddAccountCookiesDisabled) {
@@ -229,6 +233,7 @@ TEST_F(GaiaCookieManagerServiceTest, MergeSessionRetried) {
TEST_F(GaiaCookieManagerServiceTest, MergeSessionRetriedTwice) {
InstrumentedGaiaCookieManagerService helper(token_service(), signin_client());
MockObserver observer(&helper);
+ base::HistogramTester histograms;
EXPECT_CALL(helper, StartFetchingUbertoken());
EXPECT_CALL(helper, StartFetchingMergeSession()).Times(2);
@@ -254,6 +259,8 @@ TEST_F(GaiaCookieManagerServiceTest, MergeSessionRetriedTwice) {
base::MessageLoop::current()->Run();
SimulateMergeSessionSuccess(&helper, "token");
DCHECK(!helper.is_running());
+ histograms.ExpectUniqueSample("OAuth2Login.MergeSessionRetry",
+ GoogleServiceAuthError::REQUEST_CANCELED, 2);
}
TEST_F(GaiaCookieManagerServiceTest, FailedUbertoken) {
« no previous file with comments | « components/signin/core/browser/gaia_cookie_manager_service.cc ('k') | google_apis/gaia/oauth2_token_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698