Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1148173003: Changing out-of-flow-ness on a multicol child may affect the need for column sets. (Closed)

Created:
5 years, 7 months ago by mstensho (USE GERRIT)
Modified:
5 years, 7 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Changing out-of-flow-ness on a multicol child may affect the need for column sets. If a sole out-of-flow child becomes in-flow, we have to insert a column set, since we suddenly have column content. Conversely, if a sole in-flow child becomes out-of-flow, we have to remove the column set, since there's no column content anymore. BUG=486993 R=dsinclair@chromium.org,jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195693

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/fast/multicol/fixedpos-child-becomes-static.html View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/fixedpos-child-becomes-static-expected.html View 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/static-child-becomes-fixedpos.html View 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/static-child-becomes-fixedpos-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutFlowThread.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutMultiColumnFlowThread.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 7 months ago (2015-05-20 20:40:17 UTC) #1
dsinclair
lgtm
5 years, 7 months ago (2015-05-21 13:46:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148173003/1
5 years, 7 months ago (2015-05-21 13:47:05 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 15:25:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195693

Powered by Google App Engine
This is Rietveld 408576698