Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1176)

Unified Diff: Source/core/layout/LayoutMultiColumnFlowThread.cpp

Issue 1148173003: Changing out-of-flow-ness on a multicol child may affect the need for column sets. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/LayoutMultiColumnFlowThread.h ('k') | Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutMultiColumnFlowThread.cpp
diff --git a/Source/core/layout/LayoutMultiColumnFlowThread.cpp b/Source/core/layout/LayoutMultiColumnFlowThread.cpp
index 79f6c981b6cbf0063a738174366c0801e0f02fd6..51c0a42890106bbebbbca8f4a0e21e259904a6d8 100644
--- a/Source/core/layout/LayoutMultiColumnFlowThread.cpp
+++ b/Source/core/layout/LayoutMultiColumnFlowThread.cpp
@@ -642,6 +642,20 @@ void LayoutMultiColumnFlowThread::flowThreadDescendantWillBeRemoved(LayoutObject
columnSetToRemove->destroy();
}
+void LayoutMultiColumnFlowThread::flowThreadDescendantStyleWillChange(LayoutObject* descendant, StyleDifference diff, const ComputedStyle& newStyle)
+{
+ // If an in-flow descendant goes out-of-flow, we may have to remove a column set.
+ if (newStyle.hasOutOfFlowPosition() && !styleRef().hasOutOfFlowPosition())
+ flowThreadDescendantWillBeRemoved(descendant);
+}
+
+void LayoutMultiColumnFlowThread::flowThreadDescendantStyleDidChange(LayoutObject* descendant, StyleDifference diff, const ComputedStyle& oldStyle)
+{
+ // If an out-of-flow descendant goes in-flow, we may have to insert a column set.
+ if (oldStyle.hasOutOfFlowPosition() && !styleRef().hasOutOfFlowPosition())
+ flowThreadDescendantWasInserted(descendant);
+}
+
void LayoutMultiColumnFlowThread::computePreferredLogicalWidths()
{
LayoutFlowThread::computePreferredLogicalWidths();
« no previous file with comments | « Source/core/layout/LayoutMultiColumnFlowThread.h ('k') | Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698