Register bindings for blessed web contexts (aka hosted app contexts) by hand

Register bindings for blessed web contexts (aka hosted app contexts) by hand
rather than automatically; this allows them to be treated like web contexts
rather than extension contexts, which allows the more complex bindings rules
for making the messaging APIs (chrome.runtime.connect/sendMessage) available.
Make them available.

BUG=326250
R=koz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243959

[commit-bot: I haz the power, 2013-12-20 01:01:24]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[not at google - send to devlin, 2013-12-20 01:02:12]

Um, I didn't click commit..?

[koz (OOO until 15th September), 2013-12-20 03:21:22]

I'm not familiar enough with this code to do a good review here.

[not at google - send to devlin, 2013-12-20 03:31:50]

I think you may be the most familiar (from way back when).

But, sure. Jeffrey, are you confident enough to review this?

[not at google - send to devlin, 2014-01-08 02:34:09]

ping

[Jeffrey Yasskin, 2014-01-08 23:42:02]

https://codereview.chromium.org/114803007/diff/10001/chrome/browser/extension...
File chrome/browser/extensions/extension_messages_apitest.cc (left):

https://codereview.chromium.org/114803007/diff/10001/chrome/browser/extension...
chrome/browser/extensions/extension_messages_apitest.cc:229: "id",
Why is "id" dropping out of this list?

https://codereview.chromium.org/114803007/diff/10001/chrome/renderer/extensio...
File chrome/renderer/extensions/chrome_v8_context.cc (right):

https://codereview.chromium.org/114803007/diff/10001/chrome/renderer/extensio...
chrome/renderer/extensions/chrome_v8_context.cc:116: return
ExtensionAPI::GetSharedInstance()->IsAvailable(api_name,
Could you improve the ExtensionAPI::IsAvailable comment to specify how the
|extension| and |url| parameters interact?

https://codereview.chromium.org/114803007/diff/10001/chrome/renderer/extensio...
File chrome/renderer/extensions/dispatcher.cc (right):

https://codereview.chromium.org/114803007/diff/10001/chrome/renderer/extensio...
chrome/renderer/extensions/dispatcher.cc:711: case
Feature::BLESSED_WEB_PAGE_CONTEXT: {
Add a comment to
https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/common/ext...
about how adding a "blessed_web_page" context requires a change to this file
too?

[not at google - send to devlin, 2014-01-09 00:56:16]

s/Done/Done probably/

https://codereview.chromium.org/114803007/diff/10001/chrome/browser/extension...
File chrome/browser/extensions/extension_messages_apitest.cc (left):

https://codereview.chromium.org/114803007/diff/10001/chrome/browser/extension...
chrome/browser/extensions/extension_messages_apitest.cc:229: "id",
On 2014/01/08 23:42:03, Jeffrey Yasskin wrote:
> Why is "id" dropping out of this list?

runtime.id is available to hosted apps, which fails this test. I am being lazy.

https://codereview.chromium.org/114803007/diff/10001/chrome/renderer/extensio...
File chrome/renderer/extensions/chrome_v8_context.cc (right):

https://codereview.chromium.org/114803007/diff/10001/chrome/renderer/extensio...
chrome/renderer/extensions/chrome_v8_context.cc:116: return
ExtensionAPI::GetSharedInstance()->IsAvailable(api_name,
On 2014/01/08 23:42:03, Jeffrey Yasskin wrote:
> Could you improve the ExtensionAPI::IsAvailable comment to specify how the
> |extension| and |url| parameters interact?

Done.

https://codereview.chromium.org/114803007/diff/10001/chrome/renderer/extensio...
File chrome/renderer/extensions/dispatcher.cc (right):

https://codereview.chromium.org/114803007/diff/10001/chrome/renderer/extensio...
chrome/renderer/extensions/dispatcher.cc:711: case
Feature::BLESSED_WEB_PAGE_CONTEXT: {
On 2014/01/08 23:42:03, Jeffrey Yasskin wrote:
> Add a comment to
>
https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/common/ext...
> about how adding a "blessed_web_page" context requires a change to this file
> too?

Done.

[Jeffrey Yasskin, 2014-01-09 01:30:00]

lgtm

https://codereview.chromium.org/114803007/diff/10001/chrome/browser/extension...
File chrome/browser/extensions/extension_messages_apitest.cc (left):

https://codereview.chromium.org/114803007/diff/10001/chrome/browser/extension...
chrome/browser/extensions/extension_messages_apitest.cc:229: "id",
On 2014/01/09 00:56:16, kalman wrote:
> On 2014/01/08 23:42:03, Jeffrey Yasskin wrote:
> > Why is "id" dropping out of this list?
> 
> runtime.id is available to hosted apps, which fails this test. I am being
lazy.

Please update the comment to admit that, so we're not confused in the future.

https://codereview.chromium.org/114803007/diff/80001/extensions/common/extens...
File extensions/common/extension_api.h (right):

https://codereview.chromium.org/114803007/diff/80001/extensions/common/extens...
extensions/common/extension_api.h:73: // of the individual feature.
'k, not for this CL, but it's pretty hard to find where an "individual feature"
is configured.

[not at google - send to devlin, 2014-01-09 18:06:48]

https://codereview.chromium.org/114803007/diff/10001/chrome/browser/extension...
File chrome/browser/extensions/extension_messages_apitest.cc (left):

https://codereview.chromium.org/114803007/diff/10001/chrome/browser/extension...
chrome/browser/extensions/extension_messages_apitest.cc:229: "id",
On 2014/01/09 01:30:00, Jeffrey Yasskin wrote:
> On 2014/01/09 00:56:16, kalman wrote:
> > On 2014/01/08 23:42:03, Jeffrey Yasskin wrote:
> > > Why is "id" dropping out of this list?
> > 
> > runtime.id is available to hosted apps, which fails this test. I am being
> lazy.
> 
> Please update the comment to admit that, so we're not confused in the future.

Done.

https://codereview.chromium.org/114803007/diff/80001/extensions/common/extens...
File extensions/common/extension_api.h (right):

https://codereview.chromium.org/114803007/diff/80001/extensions/common/extens...
extensions/common/extension_api.h:73: // of the individual feature.
On 2014/01/09 01:30:01, Jeffrey Yasskin wrote:
> 'k, not for this CL, but it's pretty hard to find where an "individual
feature"
> is configured.

might as well mention it.

[commit-bot: I haz the power, 2014-01-09 18:07:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/114803007/180001

[commit-bot: I haz the power, 2014-01-09 19:58:48]

Change committed as 243959