Register bindings for blessed web contexts (aka hosted app contexts) by hand

chrome/renderer/extensions/chrome_v8_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/chrome_v8_context.h"
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string_split.h"
 #include "base/values.h"
@@ skipping 86 matching lines @@
 bool ChromeV8Context::IsAnyFeatureAvailableToContext(const Feature& api) {
   return ExtensionAPI::GetSharedInstance()->IsAnyFeatureAvailableToContext(
       api,
       extension_.get(),
       context_type_,
       UserScriptSlave::GetDataSourceURLForFrame(web_frame_));
 }
 
 Feature::Availability ChromeV8Context::GetAvailability(
     const std::string& api_name) {
+  // Hack: Hosted apps should have the availability of messaging APIs based on
+  // the URL of the page (which might have access depending on some extension
+  // with externally_connectable), not whether the app has access to messaging
+  // (which it won't).
+  const Extension* extension = extension_.get();
+  if (extension && extension->is_hosted_app() &&
+      (api_name == "runtime.connect" || api_name == "runtime.sendMessage")) {
+    extension = NULL;
+  }
   return ExtensionAPI::GetSharedInstance()->IsAvailable(api_name,

[Jeffrey Yasskin, 2014/01/08 23:42:03]

Could you improve the ExtensionAPI::IsAvailable comment to specify how the
|extension| and |url| parameters interact?

[not at google - send to devlin, 2014/01/09 00:56:16]

Done.

-                                                        extension_.get(),
+                                                        extension,
                                                         context_type_,
                                                         GetURL());
 }
 
 void ChromeV8Context::DispatchOnUnloadEvent() {
   module_system_->CallModuleMethod("unload_event", "dispatch");
 }
 
 std::string ChromeV8Context::GetContextTypeDescription() {
   switch (context_type_) {
@@ skipping 35 matching lines @@
   // string if a validation error has occured.
   if (DCHECK_IS_ON()) {
     if (!retval.IsEmpty() && !retval->IsUndefined()) {
       std::string error = *v8::String::Utf8Value(retval);
       DCHECK(false) << error;
     }
   }
 }
 
 }  // namespace extensions