Issue 114803004: Polish VK show/hide animation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 114803004: Polish VK show/hide animation (Closed)

Created:
7 years ago by bshe

Modified:
7 years ago

Reviewers:
James Cook

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Polish VK show/hide animation This CL did: 1. add opacity animation for VK when show/hide 2. reduce animation time to 100 ms BUG=327462 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241130

Patch Set 1 #

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc	View		3 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/114803004/20001

7 years ago (2013-12-16 19:56:00 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=205128

7 years ago (2013-12-16 21:55:14 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/114803004/20001

7 years ago (2013-12-17 00:00:45 UTC) #5

Message was sent while issue was closed.

Change committed as 241130

Expand Messages | Collapse Messages