Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4989)

Unified Diff: chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc

Issue 114803004: Polish VK show/hide animation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc
diff --git a/chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc b/chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc
index 8ed8785e7f9fc226b5017de5c78bc444572aa999..b9ed8b8df6c1cbd79308afd74abcc44f319f5634 100644
--- a/chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc
+++ b/chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc
@@ -39,7 +39,7 @@ namespace {
const char* kVirtualKeyboardExtensionID = "mppnpdlheglhdfmldimlhpnegondlapf";
// The virtual keyboard show/hide animation duration.
-const int kAnimationDurationMs = 1000;
+const int kAnimationDurationMs = 100;
Context::Type TextInputTypeToGeneratedInputTypeEnum(ui::TextInputType type) {
switch (type) {
@@ -174,6 +174,7 @@ void AshKeyboardControllerProxy::ShowKeyboardContainer(
settings.SetTransitionDuration(
base::TimeDelta::FromMilliseconds(kAnimationDurationMs));
container->SetTransform(gfx::Transform());
+ container->layer()->SetOpacity(1.0);
}
// TODO(bshe): Add animation observer and do the workspace resizing after
@@ -201,6 +202,7 @@ void AshKeyboardControllerProxy::HideKeyboardContainer(
gfx::Transform transform;
transform.Translate(0, GetKeyboardWindow()->bounds().height());
container->SetTransform(transform);
+ container->layer()->SetOpacity(0.0);
KeyboardControllerProxy::HideKeyboardContainer(container);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698