Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1147903003: Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in net/dns (Closed)

Created:
5 years, 7 months ago by HariS
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in net/dns BUG=457697 Committed: https://crrev.com/bc615d387a017d60aff03f0fac9ea47572733b04 Cr-Commit-Position: refs/heads/master@{#331528}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M net/dns/address_sorter_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/dns_transaction_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/dns/host_resolver_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/host_resolver_mojo_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/mdns_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/mock_mdns_socket_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
HariS
Please review the code changes.
5 years, 7 months ago (2015-05-26 11:15:07 UTC) #2
mmenke
LGTM
5 years, 7 months ago (2015-05-26 14:14:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147903003/1
5 years, 7 months ago (2015-05-27 03:18:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-27 04:26:51 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 04:27:45 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bc615d387a017d60aff03f0fac9ea47572733b04
Cr-Commit-Position: refs/heads/master@{#331528}

Powered by Google App Engine
This is Rietveld 408576698