Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: net/dns/dns_transaction_unittest.cc

Issue 1147903003: Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in net/dns (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/dns/address_sorter_posix.cc ('k') | net/dns/host_resolver_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/dns/dns_transaction_unittest.cc
diff --git a/net/dns/dns_transaction_unittest.cc b/net/dns/dns_transaction_unittest.cc
index 800e394d26bf4c4839526cbaa85538ba99aefa44..f5a897390a5e640a992a2ce06f04c45983cb8772 100644
--- a/net/dns/dns_transaction_unittest.cc
+++ b/net/dns/dns_transaction_unittest.cc
@@ -47,7 +47,7 @@ class DnsSocketData {
writes_.push_back(MockWrite(mode,
reinterpret_cast<const char*>(length.get()),
sizeof(uint16), num_reads_and_writes()));
- lengths_.push_back(length.release());
+ lengths_.push_back(length.Pass());
}
writes_.push_back(MockWrite(mode, query_->io_buffer()->data(),
query_->io_buffer()->size(),
@@ -67,12 +67,12 @@ class DnsSocketData {
reads_.push_back(MockRead(mode,
reinterpret_cast<const char*>(length.get()),
sizeof(uint16), num_reads_and_writes()));
- lengths_.push_back(length.release());
+ lengths_.push_back(length.Pass());
}
reads_.push_back(MockRead(mode, response->io_buffer()->data(),
response->io_buffer()->size(),
num_reads_and_writes()));
- responses_.push_back(response.release());
+ responses_.push_back(response.Pass());
}
// Adds pre-built DnsResponse.
@@ -359,7 +359,7 @@ class DnsTransactionTest : public testing::Test {
CHECK(socket_factory_.get());
transaction_ids_.push_back(data->query_id());
socket_factory_->AddSocketDataProvider(data->GetProvider());
- socket_data_.push_back(data.release());
+ socket_data_.push_back(data.Pass());
}
// Add expected query for |dotted_name| and |qtype| with |id| and response
« no previous file with comments | « net/dns/address_sorter_posix.cc ('k') | net/dns/host_resolver_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698