Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 114783002: Merge 163680 "Fix a crash when a form control is in a past naems..." (Closed)

Created:
7 years ago by tkent
Modified:
7 years ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Merge 163680 "Fix a crash when a form control is in a past naems..." > Fix a crash when a form control is in a past naems map of a demoted form element. > > Note that we wanted to add the protector in FormAssociatedElement::setForm(), > but we couldn't do it because it is called from the constructor. > > BUG=326854 > TEST=automated. > > Review URL: https://codereview.chromium.org/105693013 TBR=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163825

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
A + LayoutTests/fast/forms/past-names-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/past-names-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/html/FormAssociatedElement.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tkent
7 years ago (2013-12-12 23:46:21 UTC) #1
tkent
7 years ago (2013-12-12 23:46:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r163825.

Powered by Google App Engine
This is Rietveld 408576698