Source/core/html/FormAssociatedElement.cpp - Issue 114783002: Merge 163680 "Fix a crash when a form control is in a past naems..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/FormAssociatedElement.cpp

Issue 114783002: Merge 163680 "Fix a crash when a form control is in a past naems..." (Closed) Base URL: svn://svn.chromium.org/blink/branches/chromium/1700/

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/FormAssociatedElement.cpp

===================================================================

--- Source/core/html/FormAssociatedElement.cpp (revision 163824)

+++ Source/core/html/FormAssociatedElement.cpp (working copy)

@@ -122,8 +122,10 @@

void FormAssociatedElement::formRemovedFromTree(const Node* formRoot)

{

ASSERT(m_form);

- if (toHTMLElement(this)->highestAncestor() != formRoot)

- setForm(0);

+ if (toHTMLElement(this)->highestAncestor() == formRoot)

+ return;

+ RefPtr<HTMLElement> protector(toHTMLElement(this));

+ setForm(0);

}

void FormAssociatedElement::setForm(HTMLFormElement* newForm)

« no previous file with comments | « LayoutTests/fast/forms/past-names-crash-expected.txt ('k') | no next file » | no next file with comments »