Issue 11476005: [Spellcheck] Make sure context menu and actual spellcheck state are in sync.

Issue 11476005: [Spellcheck] Make sure context menu and actual spellcheck state are in sync. (Closed)

Created:
8 years ago by groby-ooo-7-16

Modified:
8 years ago

Reviewers:
Tom Sepez, rpetterson, brettw

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, rpetterson, sail+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, groby+spellwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Spellcheck] Make sure context menu and actual spellcheck state are in sync. R=rlp@chromium.org,tsepez@chromium.org,brettw@chromium.org BUG=162498, 162342 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172456

Patch Set 2 : Review fixes. #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -19 lines)			Patch
M	chrome/browser/profiles/profile_dependency_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/spellchecker/spellcheck_service.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/browser/tab_contents/spellchecker_submenu_observer_mac.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/spellcheck_messages.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck.h	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck.cc	View	1	5 chunks	+49 lines, -1 line	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck_provider.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck_provider.cc	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

groby-ooo-7-16

The gist of this change: Spellcheck enabled status is changed via the associated pref. Browser-side, ...

8 years ago (2012-12-06 20:10:25 UTC) #1

rpetterson

LGTM with a small nit. https://codereview.chromium.org/11476005/diff/1/chrome/renderer/spellchecker/spellcheck_provider.h File chrome/renderer/spellchecker/spellcheck_provider.h (right): https://codereview.chromium.org/11476005/diff/1/chrome/renderer/spellchecker/spellcheck_provider.h#newcode53 chrome/renderer/spellchecker/spellcheck_provider.h:53: void EnableSpellCheck(bool enabled); nit: ...

8 years ago (2012-12-06 22:21:53 UTC) #3

brettw

owners lgtm https://codereview.chromium.org/11476005/diff/1/chrome/renderer/spellchecker/spellcheck.cc File chrome/renderer/spellchecker/spellcheck.cc (right): https://codereview.chromium.org/11476005/diff/1/chrome/renderer/spellchecker/spellcheck.cc#newcode27 chrome/renderer/spellchecker/spellcheck.cc:27: class UpdateSpellcheckEnabled : public content::RenderViewVisitor { IS ...

8 years ago (2012-12-11 18:38:58 UTC) #4

groby-ooo-7-16

https://codereview.chromium.org/11476005/diff/1/chrome/renderer/spellchecker/spellcheck.cc File chrome/renderer/spellchecker/spellcheck.cc (right): https://codereview.chromium.org/11476005/diff/1/chrome/renderer/spellchecker/spellcheck.cc#newcode27 chrome/renderer/spellchecker/spellcheck.cc:27: class UpdateSpellcheckEnabled : public content::RenderViewVisitor { On 2012/12/11 18:38:58, ...

8 years ago (2012-12-11 20:19:55 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/11476005/9001

8 years ago (2012-12-11 20:21:17 UTC) #6

Message was sent while issue was closed.

Change committed as 172456

Expand Messages | Collapse Messages