Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2516)

Unified Diff: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm

Issue 11476005: [Spellcheck] Make sure context menu and actual spellcheck state are in sync. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
diff --git a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
index d32cba6fc6360862112793d930564a38b9acf251..00c0b6212f74494584d371059b5634eb8eab57aa 100644
--- a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
+++ b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
@@ -292,6 +292,8 @@ class SpellCheckRenderViewObserver : public content::RenderViewHostObserver {
return YES;
}
+ // TODO(groby): Clarify who sends this and if toggleContinuousSpellChecking:
+ // is still necessary.
if (action == @selector(toggleContinuousSpellChecking:)) {
if ([(id)item respondsToSelector:@selector(setState:)]) {
content::RenderProcessHost* host = renderWidgetHost_->GetProcess();
@@ -361,8 +363,6 @@ class SpellCheckRenderViewObserver : public content::RenderViewHostObserver {
PrefService* pref = profile->GetPrefs();
pref->SetBoolean(prefs::kEnableSpellCheck,
!pref->GetBoolean(prefs::kEnableSpellCheck));
- renderWidgetHost_->Send(
- new SpellCheckMsg_ToggleSpellCheck(renderWidgetHost_->GetRoutingID()));
}
- (void)spellCheckEnabled:(BOOL)enabled checked:(BOOL)checked {
« no previous file with comments | « chrome/browser/profiles/profile_dependency_manager.cc ('k') | chrome/browser/spellchecker/spellcheck_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698