Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1147483002: [Android] Add option to skip v14 resource verification to GN. (Closed)

Created:
5 years, 7 months ago by Kibeom Kim (inactive)
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add option to skip v14 resource verification to GN. Added to GYP recently https://codereview.chromium.org/1136953009 . Adding the same flag to GN. Also update android_tools' BUILD.gn to use v14_skip BUG=487391 Committed: https://crrev.com/e5e5dc785e37e50dafea030349ffdd534d2231e3 Cr-Commit-Position: refs/heads/master@{#330199}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M build/config/android/internal_rules.gni View 1 chunk +4 lines, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +4 lines, -0 lines 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Kibeom Kim (inactive)
5 years, 7 months ago (2015-05-15 03:23:02 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147483002/1
5 years, 7 months ago (2015-05-15 03:23:28 UTC) #4
Kibeom Kim (inactive)
5 years, 7 months ago (2015-05-15 03:23:47 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-15 03:52:18 UTC) #8
Yaron
On 2015/05/15 03:52:18, I haz the power (commit-bot) wrote: > Dry run: This issue passed ...
5 years, 7 months ago (2015-05-15 14:16:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147483002/1
5 years, 7 months ago (2015-05-15 14:52:03 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/63971)
5 years, 7 months ago (2015-05-15 14:57:54 UTC) #13
Kibeom Kim (inactive)
cjhopman@ ptal
5 years, 7 months ago (2015-05-15 18:38:30 UTC) #14
cjhopman
lgtm
5 years, 7 months ago (2015-05-15 20:42:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147483002/1
5 years, 7 months ago (2015-05-15 21:06:59 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 21:13:49 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:27:38 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5e5dc785e37e50dafea030349ffdd534d2231e3
Cr-Commit-Position: refs/heads/master@{#330199}

Powered by Google App Engine
This is Rietveld 408576698