Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1136953009: [Android] Add an option to skip v14 resource verification. (Closed)

Created:
5 years, 7 months ago by Kibeom Kim (inactive)
Modified:
5 years, 7 months ago
CC:
aurimas (slooooooooow), chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, Yaron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add an option to skip v14 resource verification. Android AAPT 21+ will automatically move attributes to a version of the XML file with -vXX resource qualifier. So we no longer need our generate_v14_compatible_resources.py script. But AAPT only drops the attributes, so if we don't use our script, we need to put left/right in addition to start/end in our layout xmls. The plan is, disabling our script for Android support library and keep using for ourselves, until we can drop the script entirely when we discontinue support for JB. TBR=cjhopman@chromium.org BUG=487391 Committed: https://crrev.com/2b7115f8e111708c1e52257c34f91dc1549c298f Cr-Commit-Position: refs/heads/master@{#329947}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M build/android/gyp/process_resources.py View 2 chunks +10 lines, -5 lines 0 comments Download
M build/java.gypi View 2 chunks +4 lines, -0 lines 2 comments Download
M build/java_apk.gypi View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
Kibeom Kim (inactive)
5 years, 7 months ago (2015-05-13 08:43:41 UTC) #2
aurimas (slooooooooow)
https://codereview.chromium.org/1136953009/diff/1/build/java.gypi File build/java.gypi (right): https://codereview.chromium.org/1136953009/diff/1/build/java.gypi#newcode165 build/java.gypi:165: 'process_resources_options': ['--v14-verify-only'] Can we delete v14-verify-only? It is only ...
5 years, 7 months ago (2015-05-13 17:21:41 UTC) #4
Kibeom Kim (inactive)
https://codereview.chromium.org/1136953009/diff/1/build/java.gypi File build/java.gypi (right): https://codereview.chromium.org/1136953009/diff/1/build/java.gypi#newcode165 build/java.gypi:165: 'process_resources_options': ['--v14-verify-only'] On 2015/05/13 17:21:41, aurimas wrote: > Can ...
5 years, 7 months ago (2015-05-13 17:33:04 UTC) #5
aurimas (slooooooooow)
lgtm
5 years, 7 months ago (2015-05-13 17:35:57 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136953009/1
5 years, 7 months ago (2015-05-13 17:37:09 UTC) #8
newt (away)
lgtm. Thanks!
5 years, 7 months ago (2015-05-13 17:52:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136953009/1
5 years, 7 months ago (2015-05-13 17:55:55 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/63393)
5 years, 7 months ago (2015-05-13 18:04:12 UTC) #14
Kibeom Kim (inactive)
ptal cjhopman@
5 years, 7 months ago (2015-05-13 18:13:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136953009/1
5 years, 7 months ago (2015-05-14 21:23:27 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 22:18:04 UTC) #18
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2b7115f8e111708c1e52257c34f91dc1549c298f Cr-Commit-Position: refs/heads/master@{#329947}
5 years, 7 months ago (2015-05-14 22:18:54 UTC) #19
cjhopman
5 years, 7 months ago (2015-05-15 18:06:47 UTC) #20
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698