Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1147343004: Fixed memory-leak in d8. It did not clean evaluation context used for executing shell commands. (Closed)

Created:
5 years, 6 months ago by Igor Sheludko
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fixed memory-leak in d8. It did not clean evaluation context used for executing shell commands. BUG=chromium:493284 LOG=N Committed: https://crrev.com/405844b5f2e9577e30454b98a1dd8a73416420db Cr-Commit-Position: refs/heads/master@{#28790}

Patch Set 1 : #

Patch Set 2 : Fixed version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -24 lines) Patch
M src/d8.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/d8.cc View 1 5 chunks +23 lines, -20 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-493284.js View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Igor Sheludko
PTAL
5 years, 6 months ago (2015-06-03 11:13:10 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-03 11:20:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147343004/40001
5 years, 6 months ago (2015-06-03 11:28:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/4800)
5 years, 6 months ago (2015-06-03 12:13:29 UTC) #9
Igor Sheludko
PTAL. The problem was that Arm implementation relies on the fact that Isolate::Current() is available ...
5 years, 6 months ago (2015-06-03 14:16:07 UTC) #10
jochen (gone - plz use gerrit)
still lgtm
5 years, 6 months ago (2015-06-03 14:21:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147343004/60001
5 years, 6 months ago (2015-06-03 14:30:16 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 6 months ago (2015-06-03 14:34:55 UTC) #14
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 14:35:06 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/405844b5f2e9577e30454b98a1dd8a73416420db
Cr-Commit-Position: refs/heads/master@{#28790}

Powered by Google App Engine
This is Rietveld 408576698