src/d8.h - Issue 1147343004: Fixed memory-leak in d8. It did not clean evaluation context used for executing shell commands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/d8.h

Issue 1147343004: Fixed memory-leak in d8. It did not clean evaluation context used for executing shell commands. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fixed version Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/d8.h

diff --git a/src/d8.h b/src/d8.h

index 1f4bee29ed9dec50847fe6ac499d0354fe344d21..aac622833194e5815bd3a0424705049a79cefea7 100644

--- a/src/d8.h

+++ b/src/d8.h

@@ -264,6 +264,7 @@ class Shell : public i::AllStatic {

static int Main(int argc, char* argv[]);

static void Exit(int exit_code);

static void OnExit(Isolate* isolate);

+ static void CollectGarbage(Isolate* isolate);

#ifndef V8_SHARED

static Handle<Array> GetCompletions(Isolate* isolate,

« no previous file with comments | « no previous file | src/d8.cc » ('j') | no next file with comments »