content/renderer/render_view_impl.h - Issue 11473027: [Android] Should not update IME status when gesture needs to be disambiguated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 11473027: [Android] Should not update IME status when gesture needs to be disambiguated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change API again in https://bugs.webkit.org/show_bug.cgi?id=107605 Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index 13c306fc2eb0c7e6be211f114467f82dfaacd8ce..245050f388e9afae6b9e0d89ca83b1c6cd08f214 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -407,6 +407,8 @@ class CONTENT_EXPORT RenderViewImpl

virtual void requestPointerUnlock();

virtual bool isPointerLocked();

virtual void didActivateCompositor(int input_handler_identifier);

+ virtual void didHandleGestureEvent(const WebKit::WebGestureEvent& event,

+ bool event_cancelled) OVERRIDE;

// WebKit::WebViewClient implementation --------------------------------------

@@ -442,8 +444,6 @@ class CONTENT_EXPORT RenderViewImpl

virtual void didChangeSelection(bool is_selection_empty);

virtual void didExecuteCommand(const WebKit::WebString& command_name);

virtual bool handleCurrentKeyboardEvent();

- virtual void didHandleGestureEvent(const WebKit::WebGestureEvent& event,

- bool event_swallowed) OVERRIDE;

virtual WebKit::WebColorChooser* createColorChooser(

WebKit::WebColorChooserClient*, const WebKit::WebColor& initial_color);

virtual bool runFileChooser(

« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | content/renderer/render_widget.h » ('J')