Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1858)

Unified Diff: content/renderer/render_view_impl.cc

Issue 11473027: [Android] Should not update IME status when gesture needs to be disambiguated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: change API again in https://bugs.webkit.org/show_bug.cgi?id=107605 Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 27954584dafce499c41ee8b697137e7d099287c6..d4ada62795ba75aeb29eb0e80b3de8545a96555d 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -2125,18 +2125,6 @@ bool RenderViewImpl::handleCurrentKeyboardEvent() {
return did_execute_command;
}
-void RenderViewImpl::didHandleGestureEvent(const WebGestureEvent& event,
- bool event_swallowed) {
-#if defined(OS_ANDROID)
- if (event.type == WebInputEvent::GestureTap ||
- event.type == WebInputEvent::GestureLongPress) {
- UpdateTextInputState(SHOW_IME_IF_NEEDED);
- }
-#endif
- FOR_EACH_OBSERVER(RenderViewObserver, observers_,
- DidHandleGestureEvent(event));
-}
-
WebKit::WebColorChooser* RenderViewImpl::createColorChooser(
WebKit::WebColorChooserClient* client,
const WebKit::WebColor& initial_color) {
@@ -2552,6 +2540,14 @@ void RenderViewImpl::didActivateCompositor(int input_handler_identifier) {
ProcessAcceleratedPinchZoomFlags(*CommandLine::ForCurrentProcess());
}
+void RenderViewImpl::didHandleGestureEvent(
+ const WebGestureEvent& event,
+ bool event_cancelled) {
+ RenderWidget::didHandleGestureEvent(event, event_cancelled);
+ FOR_EACH_OBSERVER(RenderViewObserver, observers_,
+ DidHandleGestureEvent(event));
+}
+
// WebKit::WebFrameClient -----------------------------------------------------
WebPlugin* RenderViewImpl::createPlugin(WebFrame* frame,

Powered by Google App Engine
This is Rietveld 408576698